Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Update to 113.0.5672.* #710

Closed
rwmacleod opened this issue May 4, 2023 · 10 comments · Fixed by #721
Closed

chromium: Update to 113.0.5672.* #710

rwmacleod opened this issue May 4, 2023 · 10 comments · Fixed by #721
Assignees

Comments

@rwmacleod
Copy link
Contributor

Just as we are close to finishing 112, along comes 113!
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop.html

@MaxIhlenfeldt MaxIhlenfeldt self-assigned this May 18, 2023
@MaxIhlenfeldt
Copy link
Collaborator

If no one else wants to take this, I can tackle this next week.

@nrpt-m
Copy link
Contributor

nrpt-m commented May 23, 2023

@MaxIhlenfeldt, I am looking forward to your chromium-113 update and will test it once PR is available.
Let us know, if there are any problems.

@MaxIhlenfeldt
Copy link
Collaborator

dunfell using clang 12 is once again causing problems. Would it be possible to take the same approach for using clang 14 as we took for using Node 14? I fear we else might continue to need one or two dunfell-specific patches every new version...

@kraj
Copy link
Collaborator

kraj commented May 26, 2023

it will be some effort but I think using same compiler as kirkstone on dunfell might be something doable but it will need some work and testing, because when we use newer clang system-wide then many packages may not compile with it.

@MaxIhlenfeldt
Copy link
Collaborator

I see, makes sense. I'll continue to try and make it work with clang 12, then, and we can look into using clang 14 separately in #716.

@rwmacleod
Copy link
Contributor Author

@MaxIhlenfeldt are you waiting to be able to use clang-14 on dunfell or should we try to fix the compile issues with clang-12?

If you send a PR, @nrpt-m and I could test it and perhaps help fix any compilation issues.

@MaxIhlenfeldt
Copy link
Collaborator

I'm still working on this. I now have something that compiles on kirkstone and langdale, dunfell still needs some work. Not sure if it makes sense to upload the WIP update, as changes to the patches or entirely new ones would probably mean we'd need to test the non-dunfell configurations again, right?

@rwmacleod
Copy link
Contributor Author

I'm still working on this. I now have something that compiles on kirkstone and langdale, dunfell still needs some work. Not sure if it makes sense to upload the WIP update, as changes to the patches or entirely new ones would probably mean we'd need to test the non-dunfell configurations again, right?

Sure, if you are making progress, we'll just wait to test.

If you want some input on the compilation problems, we can spend time on that if you are stuck.

@MaxIhlenfeldt
Copy link
Collaborator

If you want some input on the compilation problems, we can spend time on that if you are stuck.

Thanks! I think I now have everything patched that needs patching. Luckily, it's mostly just backports. I'll upload everything on Monday!

@MaxIhlenfeldt MaxIhlenfeldt linked a pull request Jun 5, 2023 that will close this issue
@MaxIhlenfeldt
Copy link
Collaborator

PR is up at #721!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants