Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all 2022 echoshader features #75

Closed
leewujung opened this issue May 21, 2023 · 11 comments
Closed

Test all 2022 echoshader features #75

leewujung opened this issue May 21, 2023 · 11 comments
Assignees
Labels
bug Something isn't working good future ref good reference for later

Comments

@leewujung
Copy link
Member

leewujung commented May 21, 2023

The first step for getting back to the development is to revamp and test all 2022 echoshader features.

The tests should run both locally and on EC2.

@ldr426 : please list in comments below what you have tested and document what works and what doesn't (and what the problem or suspected problem is if it does not work).

Functions Tested List

Tesing data:
Ship (10 days, 2017-07-24 to 2017-08-02)
Range meter bin = 5m
Ping time bin = 1800s

Simple Hist

image

Echogram for single gram

image

Box Select

image

Echogram for multiple grams

image

Statistic Table in Echostats

image image

Statistic histogram(single, overlay, layout) in Echostats

image image image

Map in Echomap

image

Curtain in Echomap

image
@leewujung leewujung added this to the Recap and revamp milestone May 21, 2023
@ldr426 ldr426 moved this to Done in Echoshader May 24, 2023
@leewujung leewujung moved this from Done to In Progress in Echoshader May 27, 2023
@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 1 (Solved)

Jupyter could not render holoviews/bokeh pictures correctly.
image

Possible Cause

Browser may not specify bokeh version, which causes some conflict.

Temporary soltution

Do not specify hv.extension('bokeh').
Make sure to install jupyter_bokeh after installing jupyter or ipykernel.
mamba install jupyter_bokeh
Suggestion: VS code has less corresponding time.

@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 2 (Not Solved)

When using invert_yaxis = True, echogram does not show immediately.
You can see the gram after scrolling down along the y-axis. But the value on the axis is not correct.
image
image

Possible Cause

From the package holoviews itself.
Some guys also encounter this problem.
holoviz/holoviews#5727
The old version does not have this problem.

Temporary Solution

Do not use the option invert_yaxis. There must be approach to invert y-axis correctly, which needs to be dived into later.
image
Also update code involving plotting or getting data from box
image
Need to change:
image

@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 3 (Solved)

There is no box select in tool bar.
image

Possible Cause

Unknown. In the old version, the tool icon appears in default.

Solution

Explicitly claim this tool in options
image
image

@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 4 (Not be solved)

Errors below appear when running echogram.
image

Possible Cause

May come from rasterize
image

Solution

No impact much on running. Not emergent. Need to be checked later.

@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 5 (Not be solved)

Errors below appear when tunning control widgets on panel.
image

Possible Caues

May come from conflict bewtwen different controlled grams.
One control panel is responsible for multiple grams.

Solution

No impact much on running. Not emergent. Need to be checked later.

@ldr426
Copy link
Collaborator

ldr426 commented May 31, 2023

Problem 6 (solved on June 2)

No color map rendering when plotting 3D curtain.
image

Possible Caues

Unknown.

Solution

Need to update map and curtain at once before colormap renders

@ldr426
Copy link
Collaborator

ldr426 commented Jun 2, 2023

Problem 7 (Solved)

No hover tool when plotting overlay gram+box.
image

Possible Caues

Unkown

Soultion

Explicitly declare hover tool in holoviews opt.
image
image

@ldr426
Copy link
Collaborator

ldr426 commented Jun 2, 2023

Problem 8 (Solved)

No pyvista shown in EC2

Cause

ImportError: libGL
or
pyvista/pyvista#177

Solution

in Ubuntu
sudo apt install libgl1-mesa-glx
When running jupyter:

import pyvista
pyvista.start_xvfb()

or
https://docs.pyvista.org/version/stable/getting-started/installation.html#running-on-remote-servers

@ldr426
Copy link
Collaborator

ldr426 commented Jun 2, 2023

Problem 9 (Solved on Jun 2)

Could not dynamically update 3D curtain

Cause

Unknown.
image

Possible Solution

Do below change in view_curtain method in Echomap class
image

@ldr426 ldr426 added the bug Something isn't working label Jun 2, 2023
@ldr426 ldr426 mentioned this issue Jun 5, 2023
@hoxbro
Copy link

hoxbro commented Jun 7, 2023

Problem 1: is caused by an upstream change in Jupyter, ref: holoviz/holoviews#5699 (comment). We have tried to reduce this by setting inline=False in 1.16.1.

Problem 4: It seems like a bug in Holoviews. If possible, please report it with a MRE.

Problem 9: This was a bug in Panel and is fixed in the latest release (1.1).

@ldr426 ldr426 mentioned this issue Jun 12, 2023
5 tasks
@leewujung
Copy link
Member Author

Great @ldr426 that you have a list of all the problems and causes and solutions for a subset of them in #92. I think we can close this issue now. I'm putting the "good future ref" label so that we can come back to them once the refactoring is done.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Echoshader Jun 26, 2023
@leewujung leewujung added the good future ref good reference for later label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good future ref good reference for later
Projects
Status: Done
Development

No branches or pull requests

3 participants