Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regions2D.close_region to also modify the internal dataframe? #210

Open
leewujung opened this issue Aug 9, 2024 · 1 comment
Open

Regions2D.close_region to also modify the internal dataframe? #210

leewujung opened this issue Aug 9, 2024 · 1 comment
Assignees
@ctuguinay
Labels
enhancement
Milestone
v0.3.0

Comments

@leewujung
Copy link
Member

I noticed that Regions2D.close_region right now returns a dataframe that has the regions closed, but the internal dataframe of the Regions2D object is unchanged.

I feel it would be more intuitive if the internal dataframe is modified, instead of returning a copy with the modified dataframe.

Thoughts? @ctuguinay
@ctuguinay
Copy link
Collaborator

@leewujung Ah yeah I think you're right. I'll add this

@ctuguinay ctuguinay self-assigned this Aug 9, 2024
@ctuguinay ctuguinay added this to the v0.3.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctuguinay ctuguinay

Labels
enhancement
Projects
Echoregions
Status: No status
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@leewujung @ctuguinay