Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Card Bug - Missing templates? #3937

Closed
abujeda opened this issue Nov 6, 2024 · 2 comments · Fixed by #3941
Closed

Session Card Bug - Missing templates? #3937

abujeda opened this issue Nov 6, 2024 · 2 comments · Fixed by #3941
Assignees
Labels
bug Existing functionality not working as expected
Milestone

Comments

@abujeda
Copy link
Contributor

abujeda commented Nov 6, 2024

I was looking at the session cards and I notice that there are some missing partials from previous versions

It looks like after the refactoring completed on: 50c3514 some partials for the session card didn't get included. I think that the custom_info_view and session_completed_view are missing in the new version of the session card.

Current version:
https://github.com/OSC/ondemand/blob/master/apps/dashboard/app/views/batch_connect/sessions/card/_card_body.html.erb

Should it be like this?

<div class="card-body">
  <div>
    <div class="float-end"><%= cancel_or_delete(session) %></div>
    <%= render_card_partial('host', session) %>
    <%= render_card_partial('created', session) %>
    <%= render_card_partial('session_time', session) %>
    <%= render_card_partial('id', session) %>
    <%= render_card_partial('support_ticket', session) if Configuration.support_ticket_enabled? %>
    <%= render_card_partial('display_choices', session) %>
    <%= render_card_partial('custom_info_view', session) if session.app.session_info_view %>
    <%= render_card_partial('completed_view', session) if session.app.session_completed_view &&  session.completed? %>
    <%= render_connection(session) %>
  </div>
</div>
@osc-bot osc-bot added this to the Backlog milestone Nov 6, 2024
@johrstrom johrstrom modified the milestones: Backlog, 4.0 Nov 6, 2024
@johrstrom johrstrom added the bug Existing functionality not working as expected label Nov 6, 2024
@johrstrom
Copy link
Contributor

Might could be. I'll take a look.

@moffatsadeghi
Copy link
Collaborator

Thanks for submitting this and catching this, @abujeda!

@johrstrom johrstrom self-assigned this Nov 7, 2024
@johrstrom johrstrom mentioned this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants