Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript unit tests #3882

Closed
johrstrom opened this issue Oct 17, 2024 · 1 comment
Closed

javascript unit tests #3882

johrstrom opened this issue Oct 17, 2024 · 1 comment
Milestone

Comments

@johrstrom
Copy link
Contributor

While working on #3538 I realize that we've had a lot of issues come up with this portion of our code base. Specifically snakeCaseWords and to a lesser degree mountainCaseWords.

My thinking is to pull these out so that they can be unit tested in some fashion, this is currently under system tests where we compile it and test it against a real batch connect app. This can be a bit cumbersome at times.

The shell application uses jest to run unit tests. I'd like to avoid that if possible. assert is a nodejs stdlib thing so we likely can do this in plain old javascript.

@johrstrom johrstrom added this to the Backlog milestone Oct 17, 2024
@johrstrom
Copy link
Contributor Author

Upon reflection, I think I'm going to close this. system tests are actually quite nice because they test what we'd expect as a user not just in some deep internal function. so actually lots and lots of system tests (as we currently have) I think provide pretty good coverage for regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant