bc_clean_old_dirs also cleanup db files

[stdweird]

bc_clean_old_dirs now cleans up session output dirs that are certain age; but can it be extended to cleanup also files in the db dir, eg ~/ondemand/data/sys/dashboard/batch_connect/db ? we have some users who have files there that are very very old, and reference clusters that are no longer around. afaik, these files are one per job; so shouldn't be older then max job age (but we are fine if they are cleaned eg together with the bc_clean_old_dirs logic

[johrstrom]

These files do get cleaned up after so long (7 days after it's completed is the default).

Maybe it's a case of backward comparability? Like we started to clean these files, but never cleaned the files from previous versions?

[stdweird]

@johrstrom that's possible. the old files i found were from our 2.0.X setup (and over 9 months old); but that means they were also not cleaned up by 2.0 (not sure when the cleanup was added). anyway, i will try to cleanup as much as possible; and will reopen this when i see files from 3.1 era not being cleaned up.

[johrstrom]

To be clear - here's the logic to delete them if they're old. I feel like it was added in 2.0, but would have to check to be sure.

ondemand/apps/dashboard/app/models/batch_connect/session.rb

Line 157 in de41471

(s.completed? && s.old? && s.destroy) ? nil : s

It would seem that modified_at isn't available, so it's thinking that the cards are not in fact old enough to delete.

ondemand/apps/dashboard/app/models/batch_connect/session.rb

Lines 200 to 206 in de41471

	def old?
	if modified_at.nil?
	false
	else
	modified_at < self.class.old_in_days.days.ago.to_i
	end
	end