Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky favorite tests #3438

Closed
johrstrom opened this issue Mar 20, 2024 · 1 comment · Fixed by #3439, #3449 or #3490
Closed

flaky favorite tests #3438

johrstrom opened this issue Mar 20, 2024 · 1 comment · Fixed by #3439, #3449 or #3490
Labels
bug Existing functionality not working as expected
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

#3428 added some tests for the path_selector, but apparently they're a bit flaky failing here and there for no apparent reason. This ticket is to fix those tests so they pass (given the code under test is correct too).
@johrstrom johrstrom added the bug Existing functionality not working as expected label Mar 20, 2024
@johrstrom johrstrom added this to the 4.0 milestone Mar 20, 2024
@johrstrom johrstrom mentioned this issue Mar 21, 2024
Merged
@johrstrom johrstrom mentioned this issue Mar 22, 2024
Merged
@johrstrom
Copy link
Contributor Author

These tests are still flaky so, regrettably, I'm going to reopen this ticket.

@johrstrom johrstrom reopened this Mar 29, 2024
@johrstrom johrstrom mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing functionality not working as expected
Projects
None yet
Milestone
4.0
1 participant
@johrstrom