Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned App Images Mis-aligned #3368

Closed
Oglopf opened this issue Feb 22, 2024 · 4 comments
Closed

Pinned App Images Mis-aligned #3368

Oglopf opened this issue Feb 22, 2024 · 4 comments
Milestone

Comments

@Oglopf
Copy link
Contributor

Oglopf commented Feb 22, 2024

A discourse came in pointing out that the images in the pinned apps are not quite displaying correctly.

https://discourse.openondemand.org/t/dashboard-icons-are-misaligned/3282

Only the first image seems to align center as it should, while the remaining images all align left.

This can be fixed by just adding an mx-auto to the img tag.

@osc-bot osc-bot added this to the Backlog milestone Feb 22, 2024
@Oglopf Oglopf changed the title Pinned App Image Mis-aligned Pinned App Images Mis-aligned Feb 22, 2024
@abujeda
Copy link
Contributor

abujeda commented Feb 22, 2024

I think this has been fixed already:
#3357

@Oglopf
Copy link
Contributor Author

Oglopf commented Feb 22, 2024

Sadly no, I just recreated it and can see the app images off still plus we had a user report the same problem. So, something is not right it would seem.

@abujeda
Copy link
Contributor

abujeda commented Feb 23, 2024

That is strange. The fix was specifically for the issue the user is reporting.
I cannot reproduce locally with the latest from master, where the fix is.

Could you confirm what CSS rules are applied, just to check why the fix is not working?
The rule .app-launcher .app-icon should be correcting the margin for the pinned_apps

Screenshot 2024-02-23 at 09 33 29

@Oglopf
Copy link
Contributor Author

Oglopf commented Feb 26, 2024

I didn't realize it was still sitting in master and had been building on 3.1 and not seeing the fix.

@Oglopf Oglopf closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants