Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning dockerfile to use the matching repo version instead of latest #3049

Open
Micket opened this issue Sep 15, 2023 · 1 comment
Open

Comments

@Micket
Copy link
Contributor

Micket commented Sep 15, 2023

As one of the few who uses dockerfile for my container deployment of OOD, some preventable build issues occur from time to time.

The release_3.0 branch, as well as the released 3.0 tarball, both use

RUN dnf -y install https://yum.osc.edu/ondemand/latest/ondemand-release-web-latest-1-6.noarch.rpm

and as of the appearance of ondemand-passenger-6.0.17-1.ood3.1.3.el8, this dockerfile no longer builds due to the updated ruby dependency mismatching the dnf module lock of ruby:3.0.

I'm aware of what I could do to fix this, but should the dockerfile on the release_3.0 branch not instead just use the packages from 3.0 instead of latest?

RUN dnf -y install https://yum.osc.edu/ondemand/3.0/ondemand-release-web-3.0-1.noarch.rpm

Even if the latest packages install OK, it seems like a bad idea to mix with ondemand 3.0 code.


Related note: Switching over my container builds to 3.0 repo, i also found that ondemand-python was skipped over in the 3.0 tree completely, but since latest includes everything, it's still available there. Should it perhaps be dropped from the dockerfile (or added into the 3.0 repo?)

@osc-bot osc-bot added this to the Backlog milestone Sep 15, 2023
@johrstrom
Copy link
Contributor

That Dockerfile is a bit out of maintenance since we setup rake tasks to build dev containers. Really that's all we use them for - development.

I'm considering removing it altogether or renaming it Dockerfile.example.

In any case - you're right that it should use 3.0 yum repo - and beyond that it should likely install a 3.0.x RPM instead of building it from source code.

@Oglopf Oglopf added bug Existing functionality not working as expected community request area/tech debt area/build and removed bug Existing functionality not working as expected labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants