Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileExplorer: Be able to disable ability to bulk download files from the web interface #262

Closed
ericfranz opened this issue Apr 16, 2018 · 3 comments
Closed

FileExplorer: Be able to disable ability to bulk download files from the web interface #262

ericfranz opened this issue Apr 16, 2018 · 3 comments
Labels
component/file_browser enhancement This is functionality that builds upon existing functionality.
Milestone
Backlog

Comments

@ericfranz
Copy link
Contributor

ericfranz commented Apr 16, 2018 •
edited by sync-by-unito bot
Loading

Users can still use the file editor and view file contents and api used by job constructure should still work. But these are hidden or disabled:

  1. the download button is hidden
  2. users cannot select files or directories and trigger download
  3. users cannot drag files or directories from their desktop to trigger a download of those files or directory

┆Issue is synchronized with this Asana task by Unito
@MorganRodgers MorganRodgers changed the title Be able to disable ability to bulk download files from the web interface FileExplorer: Be able to disable ability to bulk download files from the web interface Nov 12, 2019
@MorganRodgers MorganRodgers transferred this issue from OSC/ood-fileexplorer Nov 12, 2019
@ericfranz ericfranz added this to the Backlog milestone Jan 30, 2020
@ericfranz ericfranz modified the milestones: Backlog, Needs Triaged Apr 7, 2020
@ericfranz ericfranz mentioned this issue Apr 7, 2020
Closed
@johrstrom johrstrom modified the milestones: Needs Triaged, Backlog Jul 17, 2020
@sync-by-unito sync-by-unito bot mentioned this issue Dec 27, 2021
Closed
@lukew3 lukew3 added the enhancement This is functionality that builds upon existing functionality. label Jul 7, 2022
@johrstrom
Copy link
Contributor

We fixed this by setting the max download value to 0. Or at least, the only thing you can download is empty files.

Well OK - maybe we should get rid of the download button if it is 0.

@johrstrom
Copy link
Contributor

🤦‍♂️ well even then the config is file_download_dir_max so it's specific to directories not downloads generically.

@johrstrom
Copy link
Contributor

This was completed in #3236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/file_browser enhancement This is functionality that builds upon existing functionality.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@ericfranz @johrstrom @lukew3 @KinanAlAttar