From 6801043987735fcc5b82e88a9137f8636a595ee0 Mon Sep 17 00:00:00 2001
From: HazelGrant <hrandquist@osc.edu>
Date: Tue, 26 Mar 2024 12:13:25 -0400
Subject: [PATCH] Fixes pathfinger_select widget with data-hide option

---
 .../dashboard/app/javascript/dynamic_forms.js |  1 -
 .../test/system/batch_connect_widgets_test.rb | 74 +++++++++++++++++++
 2 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 apps/dashboard/test/system/batch_connect_widgets_test.rb

diff --git a/apps/dashboard/app/javascript/dynamic_forms.js b/apps/dashboard/app/javascript/dynamic_forms.js
index cce62fdcb2..4bda9bce4a 100644
--- a/apps/dashboard/app/javascript/dynamic_forms.js
+++ b/apps/dashboard/app/javascript/dynamic_forms.js
@@ -418,7 +418,6 @@ function updateVisibility(event, changeId) {
   $(`#${changeId}`).parents().each(function(_i, parent) {
     if(parent.classList.contains('form-group')) {
       changeElement = $(parent);
-      return false;
     }
   });
 
diff --git a/apps/dashboard/test/system/batch_connect_widgets_test.rb b/apps/dashboard/test/system/batch_connect_widgets_test.rb
new file mode 100644
index 0000000000..c4b4ff4b1e
--- /dev/null
+++ b/apps/dashboard/test/system/batch_connect_widgets_test.rb
@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+# TODO: Refactor batch_connect_test.rb to include tests that require slurm
+# (testing that things submit) and pull out/write tests for widgets (do not
+# require form submission) into this file - perhaps a batch_connect_test/
+# directory
+
+require 'application_system_test_case'
+require 'ood_core/job/adapters/slurm'
+
+class BatchConnectWidgetsTest < ApplicationSystemTestCase
+  def setup
+    stub_sys_apps
+    stub_user
+    Configuration.stubs(:bc_dynamic_js).returns(true)
+    Configuration.stubs(:bc_dynamic_js?).returns(true) #stub the alias too
+  end
+    
+  def stub_git(dir)
+    Open3.stubs(:capture3)
+      .with('git', 'describe', '--always', '--tags', chdir: dir)
+      .returns(['1.2.3', '', exit_success])
+  end
+    
+  def make_bc_app(dir, form)
+    SysRouter.stubs(:base_path).returns(Pathname.new(dir))
+    app_dir = "#{dir}/app".tap { |d| Dir.mkdir(d) }
+    stub_scontrol
+    stub_sacctmgr
+    stub_git(app_dir)
+    Pathname.new(app_dir).join('form.yml').write(form)
+  end
+
+  test 'path_selector can be hidden with data-hide-*' do
+    Dir.mktmpdir do |dir|
+      "#{dir}/app".tap { |d| Dir.mkdir(d) }
+      SysRouter.stubs(:base_path).returns(Pathname.new(dir))
+      stub_scontrol
+      stub_sacctmgr
+      stub_git("#{dir}/app")
+
+      form = <<~HEREDOC
+        ---
+        cluster:
+          - owens
+        form:
+          - path
+          - hide_path
+        attributes:
+          path:
+            widget: 'path_selector'
+            directory: "#{Rails.root}"
+          hide_path:
+            widget: 'select'
+            options:
+              - ['show path', 'show path']
+              - ['hide path', 'hide path', data-hide-path: true]
+      HEREDOC
+
+      Pathname.new("#{dir}/app/").join('form.yml').write(form)
+      base_id = 'batch_connect_session_context_path'
+
+      visit new_batch_connect_session_context_url('sys/app')
+
+      select('show path', from: 'batch_connect_session_context_hide_path')
+      assert find('#batch_connect_session_context_path')
+      assert find("[data-target='#batch_connect_session_context_path_path_selector']")
+
+      select('hide path', from: 'batch_connect_session_context_hide_path')
+      refute find('#batch_connect_session_context_path', visible: :hidden).visible?
+      refute find("[data-target='#batch_connect_session_context_path_path_selector']", visible: :hidden).visible?
+    end
+  end
+end
\ No newline at end of file