Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: include intermediate example notebook #46

Closed
WarmCyan opened this issue Aug 21, 2024 · 3 comments
Closed

JOSS review: include intermediate example notebook #46

WarmCyan opened this issue Aug 21, 2024 · 3 comments

Comments

@WarmCyan
Copy link
Collaborator

Added from @jhagerer openjournals/joss-reviews#6873 (comment): We go from a trivial "simple_example" notebook that's just expecting default anchors all the way to "lm_similarity_example" which adds a BERT transformer-based anchor (which has quite a few dependencies to get working.) It may be helpful to include an intermediate example that shows adding a custom anchor but doesn't require transformers to work. (word2vec was suggested as a possibility.)

@jhagerer
Copy link

@WarmCyan I would be happy with any example which does not need cuda/nvidia and gives me as a reviewer more to see and explore than the simple example.

A quick win solution could be to just change lm_similarity_example.ipynb such that it does not use cuda anymore. How about that?

@WarmCyan
Copy link
Collaborator Author

@jhagerer good suggestion, I modified that notebook to first check if cuda is available, and use cpu otherwise.

@jhagerer
Copy link

jhagerer commented Oct 6, 2024

OK, I think I have something running now to work with.

Please close the ticket. I'll take some time next weekend to try out and understand the tool more in depth.

@WarmCyan WarmCyan closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants