From 24caa05be35209a1cc7c38959f8371e38e093834 Mon Sep 17 00:00:00 2001 From: Nicolas Morales Date: Fri, 22 Mar 2024 09:13:30 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mark Hoemmen --- mdspan_copy/mdspan_copy.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mdspan_copy/mdspan_copy.md b/mdspan_copy/mdspan_copy.md index 721d179c..a9740744 100644 --- a/mdspan_copy/mdspan_copy.md +++ b/mdspan_copy/mdspan_copy.md @@ -39,18 +39,18 @@ Finally, there is some question as to whether `copy` and `fill` should return a ```c++ template -void copy(const mdspan &src, const mdspan &dst) +void copy(mdspan src, mdspan dst); template -void copy(ExecutionPolicy&& policy, const mdspan &src, const mdspan &dst) +void copy(ExecutionPolicy&& policy, mdspan src, mdspan dst); ``` [1]{.pnum} *Constraints:* - * [1.1]{.pnum} `std::is_assignable_v::reference, typename mdspan::reference>` + * [1.1]{.pnum} `std::is_assignable_v::reference, typename mdspan::reference>` is `true`. - * [1.2]{.pnum} `mdspan::rank() == mdspan::rank()` + * [1.2]{.pnum} `mdspan::rank()` equals `mdspan::rank()`. [2]{.pnum} *Preconditions:* @@ -65,10 +65,10 @@ void copy(ExecutionPolicy&& policy, const mdspan -void fill(const mdspan &dst, const T &value) +void fill(mdspan dst, const T& value); template -void fill(ExecutionPolicy&& policy, const mdspan &dst, const T &value) +void fill(ExecutionPolicy&& policy, mdspan dst, const T& value); ``` [4]{.pnum} *Constraints:* `std::is_assignable_v::reference, const T &T>`