Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Energy interpolation #34

Open
jeanlucf22 opened this issue Oct 31, 2022 · 0 comments
Open

Energy interpolation #34

jeanlucf22 opened this issue Oct 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jeanlucf22
Copy link
Collaborator

This interpolation

Thermo4PFM/src/CALPHADFreeEnergyFunctionsBinaryThreePhase.cc

Line 419 in 5d1ede0

double e = hfphi[0] * fl + hfphi[1] * fa + hfphi[2] * fb;

should happen outside that function:
-we can pass hphi instead of phi to that function
-the actual interpolation used in PFM is a three argument function
@jeanlucf22 jeanlucf22 added the enhancement New feature or request label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeanlucf22