Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRandSketchingMethod should be called setRandSketchingMethod #99

Closed
pelesh opened this issue Dec 5, 2023 · 1 comment · Fixed by #110
Closed

getRandSketchingMethod should be called setRandSketchingMethod #99

pelesh opened this issue Dec 5, 2023 · 1 comment · Fixed by #110
Assignees
@kswirydo @pelesh

Comments

@pelesh
Copy link
Collaborator

pelesh commented Dec 5, 2023

I think this should return the sketching method, not take it as input, no? I.e. this function should be called set

Originally posted by @kswirydo in #86 (comment)
@pelesh pelesh changed the title This function should be called set getRandSketchingMethod should be called setRandSketchingMethod Dec 5, 2023
@pelesh pelesh mentioned this issue Dec 5, 2023
Merged
@pelesh pelesh self-assigned this Dec 12, 2023
@pelesh pelesh mentioned this issue Dec 12, 2023
Merged
@pelesh
Copy link
Collaborator Author

pelesh commented Dec 12, 2023

get/setRandSketchingMethod functions are not implemented. I suggest we remove them from the header files until there is a need to implement them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kswirydo kswirydo

@pelesh pelesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor handlers ORNL/ReSolve
2 participants
@kswirydo @pelesh