Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding CMake macro to add ReSolve library #46

Open
pelesh opened this issue Oct 31, 2023 · 2 comments
Open

Consider adding CMake macro to add ReSolve library #46

pelesh opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels

Comments

@pelesh
Copy link
Collaborator

pelesh commented Oct 31, 2023

Consider adding a CMake macro similar to the one in GridKit.

@pelesh pelesh added this to the Hackathon milestone Oct 31, 2023
@pelesh pelesh added the cmake label Oct 31, 2023
@cameronrutherford cameronrutherford linked a pull request Nov 2, 2023 that will close this issue
@cameronrutherford cameronrutherford removed a link to a pull request Nov 2, 2023
@pelesh pelesh modified the milestones: Hackathon, First Release Nov 6, 2023
@cameronrutherford
Copy link
Collaborator

Would this also ecompass building proper support for both shared and static libraries?

Would be good then to maintain both shared and static builds in pipelines to test each configuration continually.

I then am going to say that testing this is blocked by #55, which is blocked by Spack PR

@pelesh
Copy link
Collaborator Author

pelesh commented Nov 30, 2023

  • Spack PR seems to be in a good shape and ready to merge.
  • We can build minimalistic ReSolve w/o CUDA or HIP.
  • This will indeed add support for building ReSolve as a static library, but I don't think having static build in pipelines is a high priority at this time.

@pelesh pelesh removed this from the First Release milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants