Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider target-link-libraries as you go #145

Open
pelesh opened this issue Feb 24, 2024 · 2 comments
Open

Consider target-link-libraries as you go #145

pelesh opened this issue Feb 24, 2024 · 2 comments
Assignees
Labels
cmake enhancement New feature or request

Comments

@pelesh
Copy link
Collaborator

pelesh commented Feb 24, 2024

Consider adding target link library instructions in CMake files in Re::Solve subdirectories. Currently, target link library instructions are all in CMake file in the resolve directory. Moving these commands to subdirectories would make resolve dir CMake less cluttered and more intuitive.

This was suggested by @cameronrutherford in #140 (see below).

install(FILES ${Options_HEADER_INSTALL} DESTINATION include/resolve/utilities/options)

target_link_libraries(...)

Per my previous comments, we would just be moving where the target_link_libraries call actually happens. Again, purely a cosmetic suggestion

Originally posted by @cameronrutherford in #140 (comment)

@pelesh pelesh self-assigned this Feb 24, 2024
@pelesh
Copy link
Collaborator Author

pelesh commented Feb 24, 2024

CC @cameronrutherford @kswirydo

@pelesh
Copy link
Collaborator Author

pelesh commented Jun 6, 2024

CC @superwhiskers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant