Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a preconditioner interface class. #114

Open
pelesh opened this issue Dec 14, 2023 · 0 comments
Open

Create a preconditioner interface class. #114

pelesh opened this issue Dec 14, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pelesh
Copy link
Collaborator

pelesh commented Dec 14, 2023

I think it would be a good idea to create abstract interface for iterative solver preconditioners and expose them to users. Current preconditioners we use should inherit from that interface, as well. I suggest something like this:

  • The preconditioner class implements method(s) applyPreconditioner(), possibly overloaded.
  • Preconditioner interface is exposed to users so they can write their own preconditioners.
  • Iterative solver base class should implement method setPreconditioner, which should basically set a pointer to external preconditioner instance.
  • We could wrap preconditioners we currently use in this abstract preconditioner class.

CC @kswirydo

@pelesh pelesh added the enhancement New feature or request label Dec 14, 2023
@pelesh pelesh self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant