Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities: Edit and delete icons don't have hover, active or focus states #1100

Open
dandineen opened this issue Sep 10, 2021 · 3 comments
Open

Comments

@dandineen
Copy link
Contributor

Both these icons show the standard Material tooltip on hover but the other interactive affordances are missing.

@leomendoza123
Copy link
Member

leomendoza123 commented Sep 10, 2021

Hi Dan!
I can see the hover state when using the mouse:
image
I can the focus state is there when using the keyboard navigation:
image

I think the active state does not require here.

Can you please tell us more about this issue?

I can definitely see how the add button is missing the tooltip, so we will add that here: #1106

@dandineen
Copy link
Contributor Author

Hey Leo! Thanks for flagging this up. Apologies if the initial issue raised wasn't particularly clear.

In the Edit pencil example added above there's no indication that the Edit icon (the pencil) is being hovered over, apart from the tooltip appearing. I would expect the icon to change colour on hover and on active (press). Although I set out some specific icon state styling in the style guide I think we agreed during the public page QA to stick with the Material styles. Looking at them in situ now I'm not sure the Mat defaults are clear enough to communicate what's actually going on!

The default Material hover we can see on the delete icon is pretty subtle. How difficult would it be to change the colour of the icon and the surrounding circle for the different states?

@dandineen
Copy link
Contributor Author

We're going to icebox this one and come back to it at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants