-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPOLYMER not working after start of time stepping #5684
Comments
Hi, Thanks for reaching to us. There are a few keywords that we do not support, After commenting out the few lines, it looks running fine with both the 1f and 1f1 cases. The results of the 1f1 case can be seen from the following file. Can you give more details about your finding, regarding that polymer mode is disabled? And also, which version of OPM-flow are using? Thanks. Best, |
I'm using version 2024.04 and still see this bug (after removing OLDTRAN, RSCONST and GCONTOL). Runs attached with all includes, grid and summary output data. I simplified the models to help home in on this issue with three cases:
See images below. There are two issues:
|
Thanks. Please look at my running with the case 1f1, https://github.com/user-attachments/files/17461640/summary.pdf It looks like I recompiled a 2024.4 release version, it looks like POLY1F case that you provided is also working, the following is a unfinished running (green line is my running) I do not work with installed release version, so I am not sure what happened with your running. What is the easiest way to test release build? @akva2 Regarding the long running time, it is mostly due to convergence issue, which needs more close investigation and I do not have capacity for it, sorry about that. You can try to play with the tolerances to say if you can improve the running performance. Depending on your computer, you can try run the cases with multiple processes to accelerate the running. For example you can run OPM-flow with 4 or 8 processes, mpirun -np 4 flow ... |
Kai, Thank you so much, this is a curious one it might even be some incompatibility in the release versions of some of the common libraries, so that you don't see it in your development version. Weird. I am running on Ubuntu on Windows 10 via WSL 2. I get the same issue on my laptop (MS Surface Pro 7, Intel i7) and workstation (custom build with Ryzen threadripper 32 core), fully updated on both Windows and Ubuntu sides, although still showing some very minor differences between the platforms.
|
So on both platforms, the polymer mode does not work for POLY1F case for you. Then we need to check the release build. I build a release for 2024.04 locally, the polymer mode works for POLY1F. |
Could this be something to do with Octave, or a common library that is incompatible between Flow and ResInsight? I see this in the apt upgrade output:
Then
Not seen this before, possible a new problem. |
yeah, this is a new problem. i'll have to fix up the packaging, for some reason a shared object has ended up in both of the packages. for now, unless you need it, remove the octave-resinsight package. |
Just FYI, I did sudo apt autoremove and full-upgrade on both machines, then removed octave-resinsight. Unfortunately the problem persists: Poly1f fails, Poly2f runs but slowly. Grateful for your attention, with any luck this might expose and help you resolve some sort of nasty internal issue. On the solver side I have noticed for example that the solver is slow whenever there is a 4th component including thermal runs. |
One small update. I tested in build release with the following command,
with this build, the polymer mode works with POLY1F. It is out of my knowledge on what happened with your installation. |
Well I tried these and no luck so I'm not sure what that leave you if you cannot reproduce the issue. Seems very odd to me. Can you push this issue around your developer base see if anyone has ideas. Thing is the student this comes from sees the same thing and has a completely fresh installation of Ubuntu made last week for this project, so I dont think a complete reinstall will necessarily be an answer.
|
The only difference that I can see is that you are using Ubuntu 22.04 and I am using Ubuntu 24.04. I am not an expert in packaging, not sure whether it matters. |
I get a message in the login phase
which ties to this discussion, so I am mid process of updating and will get back to you shortly First on Windows command prompt (Admin)
Then in the Ubuntu shell ... ongoing (its a rather long process) |
Long install process followed by restarting WSL and Ubuntu
and reinstall OPM
... and ... drumroll ... no change in the result for poly1f run. Sorry ... |
I reproduced your problem now. For your case, when I ran with 3 or more processes, poly1f does not show correct behavoir. When I ran with 1 or 2 processes, poly1f shows desired behavoir. Both the development branch and release branch have the same problem. So there is a bug for the parallel running related to your polymer case. For now I can only suggest you run the cases with 1 or 2 processes. I am not sure whether we can prioritize the fix because there is not much polymer development at the moment. But we will keep it in mind. Please let us know whether you see desired results with 1 or 2 processes? |
Checking the output, it also confirms that when the polymer mode not working, there is indeed no polymer existing in the field. |
It is related to the parallel distribution of the wells after parsing the DATA file. We will see whether we can fix it easily. You will hear from us if there is any update. |
Great - that is some impressive detective work there. For the time being the workaround (that you can circulate to interested users) is to have duplicate wells as the polymer injector and switch these via WELOPEN. Would you like me to submit the more general polymer solver issue as a separate issue ? To me it seems related to other circumstances where the 4th component is used, including a lot of my Geothermal work (black oil TEMP model) and CCS in black oil with the Solvent method (per Matthias & Oldenberg). |
sure, that will be great! I am in progress in debugging the current case at the moment. |
Ok will do. I think I will check the solver on the Thermal and CCS cases, if these have a common pattern I can whizz up a set of simplified test decks to you guys to target in debugging. |
much appreciated! |
@EdmundStephens thanks for reporting this issue. With the help of some colleague, we figured out the issue and proposed a fix OPM/opm-common#4277 . We are in the final stage of publishing new release of 2024.10. Not sure whether the fix can enter this release. It if did not, the fix can only be available for the simulator compiled from the source code until the later release in 2025.4. Will keep you updated with the issue. |
My colleague just confirmed that the fix will go in the 2024.10 release. So within about a week, you can have a new version of OPM-flow will not have the same issue (polymer not working in parallel running. ) |
[v2024.04] The attached example pair shows a polymer model run. Using WPOLYMER to assign polymer injection to a well after start of time stepping does not work, in fact it seems to disable the polymer mode altogether. The workaround is to use separate injectors for water and polymer water, this is possible in simple test cases but not handy to arrange in complex cases.
I had the chance to run the R1_SS_poly1f1 in tNavigator which resulting in the correct polymer injection.
bug_WPOLYMER.zip
The text was updated successfully, but these errors were encountered: