Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle project not found situations for mining scripts #86

Open
penyuan opened this issue Apr 15, 2021 · 0 comments
Open

Handle project not found situations for mining scripts #86

penyuan opened this issue Apr 15, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@penyuan
Copy link
Contributor

penyuan commented Apr 15, 2021

During the GitHub Actions run of the mining script today, it failed with:

Processing: https://wikifactory.com/+elektrictube/pikon-telescope
Retrieving +elektrictube/pikon-telescope's data...

...

  File "osmine/miner/Wikifactory.py", line 550, in Wikifactory
    response_data: dict = get_project_data(repo_url=repo_url)
  File "osmine/miner/Wikifactory.py", line 366, in get_project_data
    if response["license"] is None: 
TypeError: 'NoneType' object is not subscriptable

I checked and turns out https://wikifactory.com/+elektrictube/pikon-telescope is not at https://wikifactory.com/+elektricworks/pikon-telescope (they changed their name?). So I think the Wikifactory API is returning some sort of "project not found" error leading to the error above.

I suspect this can be solved more comprehensively by making the mining scripts handle situations where not only invalid repository URLs but also URLs leading to repository not found.

@penyuan penyuan added the bug Something isn't working label Apr 15, 2021
@penyuan penyuan self-assigned this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant