Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dealing with missing values #8

Merged
merged 5 commits into from
Apr 11, 2024
Merged

feat: dealing with missing values #8

merged 5 commits into from
Apr 11, 2024

Conversation

ritikgupta65
Copy link
Contributor

@ritikgupta65 ritikgupta65 commented Apr 10, 2024 •
edited by TheMimikyu
Loading

Description

i have removed have missing values

Semver Changes

  • Minor (new features, no breaking changes)

#1

List any issues that this pull request closes.

Checklist

@TheMimikyu TheMimikyu added PR:Review PR is under review and can/will need some changes Semver:patch PR will only force a patch update which includes bug fixes Type:Easy PR is accepted with difficulty level as easy labels Apr 11, 2024
TheMimikyu
TheMimikyu requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly remove .ipynb_checkpoints folder from your pull request, it pollutes the codebase.

TheMimikyu
TheMimikyu requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make the requested changes.
The Rest looks good to me.

notebook.ipynb Outdated Show resolved Hide resolved
notebook.ipynb Outdated Show resolved Hide resolved
notebook.ipynb Outdated Show resolved Hide resolved
TheMimikyu
TheMimikyu approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to Me! @ritikgupta65 Thank You for the contribution.

@TheMimikyu TheMimikyu added PR:Accept PR has been accepted and is merged and removed PR:Review PR is under review and can/will need some changes labels Apr 11, 2024
@TheMimikyu TheMimikyu merged commit cf3b3d0 into OPCODE-Open-Spring-Fest:main Apr 11, 2024
3 of 4 checks passed
@TheMimikyu
Copy link
Collaborator

Issue #1 has been resolved by @ritikgupta65.

@TheMimikyu TheMimikyu mentioned this pull request Apr 11, 2024
Closed
1 task
@TheMimikyu TheMimikyu added Issue:enhancement issue is created to enhance and already present component Semver:minor PR will force a minor update in repo and includes new features and backward compatibility and removed Semver:patch PR will only force a patch update which includes bug fixes labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMimikyu TheMimikyu TheMimikyu approved these changes

Assignees
No one assigned
Labels
Issue:enhancement issue is created to enhance and already present component PR:Accept PR has been accepted and is merged Semver:minor PR will force a minor update in repo and includes new features and backward compatibility Type:Easy PR is accepted with difficulty level as easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritikgupta65 @TheMimikyu