Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect ratio not working #258

Closed
broadpeter opened this issue Aug 23, 2024 · 2 comments · Fixed by #269
Closed

Aspect ratio not working #258

broadpeter opened this issue Aug 23, 2024 · 2 comments · Fixed by #269
Assignees
@sam-ctrl

Comments

@broadpeter
Copy link
Collaborator

Line chart (and potentially other charts) has an aspect ratio setting in config but this is not referenced in script.
Instead height is hard coded in script and same for different chart widths leading to poorly proportioned charts on certain sizes, esp mobile
@sam-ctrl
Copy link
Collaborator

sam-ctrl commented Nov 5, 2024

This is still an issue, for the line chart the height is fixed at 400 pixels

@henryjameslau
Copy link
Member

No way!

@sam-ctrl sam-ctrl self-assigned this Nov 20, 2024
sam-ctrl added a commit that referenced this issue Nov 20, 2024
@sam-ctrl
Aspect ratio not working
51197df 
Fixes #258
@sam-ctrl sam-ctrl mentioned this issue Nov 20, 2024
Merged
sam-ctrl added a commit that referenced this issue Dec 18, 2024
@sam-ctrl
Aspect ratio not working
55709ca 
Fixes #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-ctrl sam-ctrl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aspect ratio not working ONSvisual/Charts
3 participants
@henryjameslau @sam-ctrl @broadpeter