Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures when calling Party service are not handled correctly #56

Open
NickGrantCEO opened this issue Jul 20, 2018 · 1 comment
Open

Comments

@NickGrantCEO
Copy link

There's a lot of complex internal queuing logic for creating a party for each sample unit, but in the event that the party service gets an I/O exception or returns a non-2XX response, we will fail with only a log message and the system will be left in an inconsistent state.

Code:
PartySvcClientServiceImpl.java - line 57 & 63

If we get a 4XX or a 5XX, or an unparseable response, we should throw an exception so that the POST is retried. If the POST fails for all the retry attempts, we need to throw an exception to the caller so that the message isn't consumed from the queue, leaving the system in an inconsistent state.

We could end up with parties missing for some SampleUnits.

@benjefferies
Copy link
Contributor

I don't think the library has been fully understood when people have been implementing these API calls. I'm pretty sure spring throws a runtime exception of time RestClientException when it gets a > 400 code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants