You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a lot of complex internal queuing logic for creating a party for each sample unit, but in the event that the party service gets an I/O exception or returns a non-2XX response, we will fail with only a log message and the system will be left in an inconsistent state.
Code:
PartySvcClientServiceImpl.java - line 57 & 63
If we get a 4XX or a 5XX, or an unparseable response, we should throw an exception so that the POST is retried. If the POST fails for all the retry attempts, we need to throw an exception to the caller so that the message isn't consumed from the queue, leaving the system in an inconsistent state.
We could end up with parties missing for some SampleUnits.
The text was updated successfully, but these errors were encountered:
I don't think the library has been fully understood when people have been implementing these API calls. I'm pretty sure spring throws a runtime exception of time RestClientException when it gets a > 400 code
There's a lot of complex internal queuing logic for creating a party for each sample unit, but in the event that the party service gets an I/O exception or returns a non-2XX response, we will fail with only a log message and the system will be left in an inconsistent state.
Code:
PartySvcClientServiceImpl.java - line 57 & 63
If we get a 4XX or a 5XX, or an unparseable response, we should throw an exception so that the POST is retried. If the POST fails for all the retry attempts, we need to throw an exception to the caller so that the message isn't consumed from the queue, leaving the system in an inconsistent state.
We could end up with parties missing for some SampleUnits.
The text was updated successfully, but these errors were encountered: