requires: check for existence of keyword - v2 #12173
Closed
+106
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, "requires: foo bar" is an unknown requirement, however its not tracked, nor an error as it follows the syntax. Instead, record these unknown keywords, and fail the requirements check if any are present. A future version of Suricata may have new requires keywords, for example a check for keywords. Ticket: OISF#7418
To be used by the requires keyword to check for keyword support. Ticket: OISF#7403
For example:
requires: keyword foo;
Will require that Suricata supports the "foo" keyword.
Ticket: OISF#7403
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12173 +/- ##
==========================================
+ Coverage 49.81% 49.85% +0.04%
==========================================
Files 909 909
Lines 257904 257949 +45
==========================================
+ Hits 128467 128597 +130
+ Misses 129437 129352 -85
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I think this looks good. The only thing I'm missing is an entry into the upgrade doc. It's a behavior change. |
|
Information: QA ran without warnings. Pipeline 23594 |
|
Replaced by #12177. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12138
Changes from previous PR:
Ticket for requires keyword: https://redmine.openinfosecfoundation.org/issues/7403
Ticket for unknown requirements: https://redmine.openinfosecfoundation.org/issues/7418
SV_BRANCH=OISF/suricata-verify#2133