createst: Allow to exclude certain fields #2135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: #4062
catenacyber
reviewed
Nov 27, 2024
| if isinstance(data, dict): | ||
| filtered_data = {} | ||
| for k, v in data.items(): | ||
| full_key = f"{base_key}.{k}" if base_key else k |
There was a problem hiding this comment.
Will we not compare "timestamp" and ".timestamp" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #4062
Hey @catenacyber what do you think now? Its still excuding the nested fields and i have tried to include skip_fields...any advice