-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svg:
prefix breaks detection as SVG file
#47
Comments
@aamnah Thank you for the comment and issue. @chris-little and @tomkralidis will discuss offline. But the reasons are almost certainly historical.
|
Thank you for taking the time out to explain it for me :) Let me know what kind of work is required for the bicolour versions and maybe i can contribute? I have already got a Figma file going here for my own use case. If my understanding of bicolour version is correct, then it is multi-color icons in SVG and nothing too domain specific and technical. Feel like i should be able to handle. |
@aamnah If you loook at my original fork of this repo you will see that the SVGs renders correctly, even though they have the |
I'm not sure what would have happened over the years, the syntax appears pretty much the same. Any XML parser should treat the below functionally equivalent, i.e.: Explicit namespacing (master branch) <svg:svg xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:cc="http://creativecommons.org/ns#" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:svg="http://www.w3.org/2000/svg" version="1.1" width="55" height="55" viewBox="0 0 55 55" id="svg3816"> Implicit namespacing <svg xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:cc="http://creativecommons.org/ns#" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns="http://www.w3.org/2000/svg" version="1.1" width="55" height="55" viewBox="0 0 55 55" id="svg3816"> Having said this, I've issued #49 with implicit namespacing for testing/review. If this works for your use case @aamnah, we can merge given they also pass CI. |
Hi, i'm a web developer currently designing a weather app and landed here after coming across this presentation. Great work with the SVGs!
Is there any particular reason we have tags like
svg:svg
,svg:title
,svg:description
,svg:metadata
,svg:g
and so on in the files? They seem to break preview on Github and make it impossible for design tools like Figma to detect them as SVGs. If i remove thesvg:
prefix, they are detected without any issues. To be honest, i have never seen thissvg:
prefix in my years of web development, so really curious as to why it is there. Scripting reasons maybe?On Github, i get the code
Error rendering embedded code. Invalid image source.
On Figma, i get
Failed to import. Unable to convert SVG
In order to make them usable (in design tools that are not Inkscape), I was able to update all files with a bash one liner
The text was updated successfully, but these errors were encountered: