Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check core submodule version is consistent with base image core version #443

Open
kba opened this issue Jun 28, 2024 · 0 comments
Open

Check core submodule version is consistent with base image core version #443

kba opened this issue Jun 28, 2024 · 0 comments

Comments

@kba
Copy link
Member

kba commented Jun 28, 2024

          > CI [failed as expected](https://app.circleci.com/pipelines/github/OCR-D/ocrd_all/1078/workflows/46661fe9-14c5-4eda-a549-959c7d1da24d/jobs/1489?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) with
ocrd/core-cuda:v2.65.0 inconsistent with core version v2.65.0-1-gcc6ea575

which is good, but I update core in this PR as well to make sure it won't if all is set up properly.

Ah, but of course there is a catch. The check won't work if we derive from a non-versioned Docker base image such as ocrd/core:minimum-cuda.

I still think the check is a good idea and will open an issue for it but comment it out for now because we really need a new release urgently.

Originally posted by @kba in #442 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant