Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #18

Closed
IanHopkinson opened this issue Mar 24, 2024 · 6 comments
Closed

Improve test coverage #18

IanHopkinson opened this issue Mar 24, 2024 · 6 comments
Labels

Comments

@IanHopkinson
Copy link
Collaborator

Currently test coverage is not great:

image

In practice new commands are tested on the CLI. Most commands are "read" actions so relatively low risk. Potentially the commands in DEMO.md could be run in a shell script to provide some confidence that all is working.

@IanHopkinson
Copy link
Collaborator Author

Added a shell script with all the ready only commands in #21

@IanHopkinson IanHopkinson mentioned this issue Apr 6, 2024
2 tasks
@IanHopkinson
Copy link
Collaborator Author

Coverage now at 65% overall

@IanHopkinson
Copy link
Collaborator Author

Improving in #24

@IanHopkinson
Copy link
Collaborator Author

image

Test coverage is rather improved, the missing pieces are tests for the add_quickchart and add_showcase because this is potentially destructive and requires a degree of setup. Perhaps best to merge this rather than waiting for perfection

@IanHopkinson
Copy link
Collaborator Author

Added tests for add_quickcharts and add_showcase against a test dataset. Happy with this coverage, the cli is a thin skin on the hdx_utilities:
image

@IanHopkinson
Copy link
Collaborator Author

Fixed with #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant