[14.0][IMP] stock_reception_screen_measuring_device: measure smaller packages #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gurneyalex, |
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
2 times, most recently
from
39f3eff
to
8c14d42
Compare
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
8c14d42
to
53747e7
Compare
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
53747e7
to
bed9739
Compare
sebalix
approved these changes
Nov 5, 2024
Comment on lines
+10
to
+15
| cr.execute( | ||
| """ | ||
| ALTER TABLE stock_reception_screen | ||
| ADD COLUMN IF NOT EXISTS smaller_package_has_missing_dimensions BOOLEAN; | ||
| """ | ||
| ) |
There was a problem hiding this comment.
Not blocking, but there are odoo.tools.sql.create_column helper for that.
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
2 times, most recently
from
84dbac6
to
e75c92e
Compare
simahawk
approved these changes
Nov 6, 2024
stock_reception_screen_measuring_device/models/stock_reception_screen.py
Outdated
Show resolved
Hide resolved
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
e75c92e
to
d6769e8
Compare
|
This PR has the |
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
d6769e8
to
720e078
Compare
grindtildeath
approved these changes
Nov 8, 2024
stock_reception_screen_measuring_device/migrations/14.0.2.0.0/post-migration.py
Show resolved
Hide resolved
stock_reception_screen_measuring_device/models/stock_reception_screen.py
Show resolved
Hide resolved
stock_reception_screen_measuring_device/models/stock_reception_screen.py
Show resolved
Hide resolved
sebalix
reviewed
Nov 19, 2024
stock_reception_screen_measuring_device/models/stock_reception_screen.py
Show resolved
Hide resolved
mmequignon
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
720e078
to
cd6ee21
Compare
When goods are received, triggers measurements also for smaller packagings that weren't ordered or received. This behavior is not triggered when received packagings are not the same as ordered packagings.
There's no need to store this flag as it's used only for UI purpose on the rec screen. This way useless computation to update the field are avoided.
simahawk
force-pushed
the
14.0-reception_screen_measuring_device-measure_smaller_packages
branch
from
cd6ee21
to
4afe798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When goods are received, triggers measurements also for smaller packagings that weren't ordered or received.
This behavior is not triggered when received packagings are not the same as ordered packagings.