Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] shopfloor: zone picking is package not valid #720

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[14.0][IMP] shopfloor: zone picking is package not valid #720

merged 1 commit into from
Aug 23, 2023

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Aug 10, 2023 •
edited
Loading

  • a package is now also not valid if it already contains move lines from an other picking type

cc @jbaudoux

Maybe we should consider to check the unload_package_at_destination configuration,
because it only would make problems if there is a difference in the shopfloor menu configuration of unload_package_at_destination

@mt-software-de mt-software-de changed the title [IMP] shopfloor: zone picking is package not valid [14.0][IMP] shopfloor: zone picking is package not valid Aug 10, 2023
@mt-software-de mt-software-de force-pushed the 14.0-imp-shopfloor-zone-picking-package-select branch 2 times, most recently from 3f5ffaa to ea3782a Compare August 11, 2023 07:54
jbaudoux
jbaudoux requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a test for the new addition.

Besides that, this is a nice improvement

shopfloor/services/zone_picking.py Outdated Show resolved Hide resolved
@mt-software-de mt-software-de force-pushed the 14.0-imp-shopfloor-zone-picking-package-select branch from ea3782a to dcef43a Compare August 14, 2023 09:47
@mt-software-de
[IMP] shopfloor: zone picking is package not valid
9cc0168 
- a package is now also not valid
  if it already contains move lines from
  an other picking type
@mt-software-de mt-software-de force-pushed the 14.0-imp-shopfloor-zone-picking-package-select branch from dcef43a to 9cc0168 Compare August 14, 2023 14:34
@mt-software-de
Copy link
Contributor Author

It's missing a test for the new addition.

Besides that, this is a nice improvement

Tests are added.

simahawk
simahawk approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #720 into 14.0
1099700 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #720 into 14.0
eca0449 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #720 into 14.0
0ac6b72 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #720 into 14.0
da4abab 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #720 into 14.0
fb5beae 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-720-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 058c3b7 into OCA:14.0 Aug 23, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ccf353c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mt-software-de @simahawk @OCA-git-bot @jbaudoux