-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0] [MIG] storage_image_product_brand: Migration to 15.0 #394
Open
bizzappdev
wants to merge
25
commits into
OCA:15.0
Choose a base branch
from
BizzAppDev-Systems:15.0-mig-storage_image_product_brand-BAD
base: 15.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[15.0] [MIG] storage_image_product_brand: Migration to 15.0 #394
bizzappdev
wants to merge
25
commits into
OCA:15.0
from
BizzAppDev-Systems:15.0-mig-storage_image_product_brand-BAD
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizzappdev
force-pushed
the
15.0-mig-storage_image_product_brand-BAD
branch
from
October 1, 2024 10:40
12f9bcb
to
c334681
Compare
The URL for all storage files is normally computed via backend. This ensures that if you have different conf by env you won't mess up w/ images coming from other envs (eg: prod). This change makes sure that the URL which is used for the thumbs is always computed by the backend.
…oduct instead of storage_image
bizzappdev
force-pushed
the
15.0-mig-storage_image_product_brand-BAD
branch
from
October 1, 2024 10:59
c334681
to
752f6d3
Compare
/ocabot migration storage_image_product_brand |
lmignon
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.