Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] base_user_role: default roles #319

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] base_user_role: default roles #319

wants to merge 1 commit into from

Conversation

danielduqma
Copy link

When granting access to a contact, a copy from Portal User Template is made for it. But applied default roles are the ones from Default User Template, causing an error when trying to assign both internal and portal types to new user.

Steps to reproduce

  1. Create a new role, assigning it group User types / Internal User
  2. Assign this role to user Default User Template
  3. Grant access to a res.partner (Actions > Grant portal access and then GRANT ACCESS)

image

FL-556-4543

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @novawish, @jcdrubay,
some modules you are maintaining are being modified, check this out!

@danielduqma
[FIX] base_user_role: default roles
e1fcd31 
When granting access to a contact, a copy from Portal User Template
is made for it. But applied default roles are the ones from Default
User Template, causing an error when trying to assign both internal
and portal types to new user.
@danielduqma danielduqma marked this pull request as ready for review October 30, 2024 12:41
miguelcb2003
miguelcb2003 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@miguelcb2003 miguelcb2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#319 from OCA/16.0
668ea3b 
Syncing from upstream OCA/server-backend (16.0)
StefanRijnhart
StefanRijnhart reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix! Can you maybe reproduce the error in a test to guarantee your fix will keep on working in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart left review comments

@miguelcb2003 miguelcb2003 miguelcb2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielduqma @OCA-git-bot @StefanRijnhart @miguelcb2003