[MIG] base_dav: Migration to 17.0 #269

jaydeep32 · 2024-02-14T16:33:52Z

To install and use this module, use the right version of radicale==2.1.12 python package.
This PR for this #254

Currently translated at 100.0% (62 of 62 strings) Translation: server-backend-17.0/server-backend-17.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/es/

Currently translated at 100.0% (62 of 62 strings) Translation: server-backend-17.0/server-backend-17.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/it/

Currently translated at 100.0% (11 of 11 strings) Translation: server-backend-14.0/server-backend-14.0-base_user_role_company Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/

Issue found on logout / relogin. The user groups were applied correctly, but the main menu showed apps the user did not have access to. This was related to the menu caching mechanisn, that was disabled here.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-14.0/server-backend-14.0-base_user_role_company Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/

Currently translated at 90.9% (10 of 11 strings) Translation: server-backend-14.0/server-backend-14.0-base_user_role_company Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-16.0/server-backend-16.0-base_user_role_company Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/

Currently translated at 100.0% (8 of 8 strings) Translation: server-backend-16.0/server-backend-16.0-base_user_role_company Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/es/

jaydeep32 · 2024-03-18T22:27:54Z

Hi, @dreispt. Copying the commit from 11.0 and adding it to this branch is very complex for me, so is it okay if I make a new PR with an 11.0 history for this module, and then we can close this one?

dreispt · 2024-03-19T16:06:50Z

@jaydeep32 Did you try the migration recipe, replacing 15.0 with 11.0?
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

jaydeep32 · 2024-03-19T17:43:38Z

Yes, I have, but like in my current branch if I make this, it makes many conflicts with new module changes, making it harder to resolve. However, it would work well if I created a new branch and then did this. So this is why I asked if I could make a new branch and PR.

dreispt · 2024-03-20T11:36:06Z

@jaydeep32 Yes, you should use the recipe to create a new clean branch, and after that add your migration changes.
Let me know if you need help.

Co-authored-by: Yannick Vaucher <[email protected]>

…rver-backend into 17.0-mig-base_dav

jaydeep32 · 2024-03-20T14:23:16Z

Hello @dreispt Now is it ok? I have added those commits from 11.0 to this one.

dreispt · 2024-03-20T14:41:04Z

base_dav/__manifest__.py

@@ -19,6 +20,6 @@
        "security/ir.model.access.csv",
    ],
    "external_dependencies": {
-        "python": ["radicale"],
+        "python": ["radicale==2.1.12"],


Can this be >= ?

Here, I use this specific module version because this module's code is only compatible with this 2.1.12 or older version of radical. If you check this #254 issue here, @AquaMCU has mentioned that he is having this strange error in the log,
so I solved that by changing the module version to radicale==2.1.12.

Also, if possible, can we add @AquaMCU to the discussion since he is the one who has migrated the module?
Actually, he was not able to create PR, so I simply made that for him

dreispt · 2024-03-20T14:43:12Z

base_dav/models/dav_collection.py

    def eval(self):
        if not self:
            return self.env["unknown"]
        self.ensure_one()
+        self = self.with_user(SUPERUSER_ID)


This raises security concerns, why is this required?

amh-mw

@jaydeep32 This doesn't look right. Why are there commits specific to the base_user_role_company module? I second @dreispt 's comment that you need to start fresh with a clean local folder and follow the steps in the migration documentation.

dreispt · 2024-03-20T14:45:42Z

@jaydeep32 Great work, you made it!
Now I can see your migration changes.
I made a couple of questions, thanks.

dreispt · 2024-03-20T14:58:41Z

@amh-mw You're right.
@jaydeep32 I ran the migration process myself and applied your changes, here #276
This has the correct history.

I suggest you fetch my branch, git reset this branch to it, and continue from there.

flotho

thanks for this PR.
I thinks some ACL are missing for http://oca-server-backend-17-0-pr269-360893ee9167.runboat.odoo-community.org/web?debug=1#id=1&cids=1&menu_id=65&action=77&model=dav.collection&view_type=form

flotho · 2024-07-11T19:27:26Z

thanks for this PR. I thinks some ACL are missing for http://oca-server-backend-17-0-pr269-360893ee9167.runboat.odoo-community.org/web?debug=1#id=1&cids=1&menu_id=65&action=77&model=dav.collection&view_type=form

mostly impossible to configure this in the UI

eLBati · 2024-07-29T10:44:27Z

Should we move to #276 ?

josselex · 2024-10-05T08:55:10Z

Is there any progress on it? Maybe even upgrading it to Odoo 18? Can we sponsor this?

Syncing from upstream OCA/server-backend (12.0)

jaydeep32 and others added 30 commits February 14, 2024 11:31

[MIG] base_dav: Migration to 17.0

7844e6e

[IMP] base_dav: Some test cases fixes,odoo tools safe_eval fixes.

5e3179e

[IMP] base_dav: pre-commit auto fixes

a244bd5

[UPD] base_dav: python package version

10d533d

[UPD] base_dav: Module external_dependencies with version.

804cce3

Translated using Weblate (Spanish)

a14edea

Currently translated at 100.0% (62 of 62 strings) Translation: server-backend-17.0/server-backend-17.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/es/

Translated using Weblate (Italian)

2efc7ea

Currently translated at 100.0% (62 of 62 strings) Translation: server-backend-17.0/server-backend-17.0-base_user_role Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/it/

[ADD] base_user_role_company: add per company user roles

a6546d7

[UPD] Update base_user_role_company.pot

e063507

[UPD] README.rst

0fba526

[ADD] icon.png

5a15310

[FIX] base_user_role_company: wrong xpath

2976844

base_user_role_company 14.0.1.1.0

9752e9c

Added translation using Weblate (Italian)

b7c3aa6

[FIX] base_user_role_company: roles not properly applied on login

31b92c7

[FIX] base_user_role_company: wrong menus on re-login

b0b99e0

Issue found on logout / relogin. The user groups were applied correctly, but the main menu showed apps the user did not have access to. This was related to the menu caching mechanisn, that was disabled here.

[FIX] base_user_role_company: fix tests

e81489f

[UPD] Update base_user_role_company.pot

8e0628d

base_user_role_company 14.0.2.0.0

677b853

base_user_role_company 14.0.2.0.1

20abc76

[IMP] base_user_role_company: pre-commit stuff

581fb46

[MIG] base_user_role_company: Migration to 16.0

81827d8

[UPD] Update base_user_role_company.pot

a06728a

[UPD] README.rst

4f3f215

Added translation using Weblate (Spanish)

2d62260

hbrunn and others added 13 commits March 20, 2024 10:06

[ADD] base_dav

32f575a

Fix CI errors

54b7a7f

Mute radicale logger for testing

dd23c30

Use the collection as first argument in the creation of the items

e194c4a

Use related model_id field to build domain

f1a711c

Set default id for fields

f9b5973

Co-authored-by: Yannick Vaucher <[email protected]>

Add missing quotation

555cf49

[UPD] Update base_dav.pot

b5b9e20

[UPD] README.rst

8b51c3e

[UPD] README.rst

3911e59

[IMP] base_dav: pre-commit auto fixes

596854d

[MIG] base_dav: Migration to 17.0

9106fc5

Merge branch '17.0-mig-base_dav' of https://github.com/archeti-org/se…

360893e

…rver-backend into 17.0-mig-base_dav

dreispt reviewed Mar 20, 2024

View reviewed changes

amh-mw suggested changes Mar 20, 2024

View reviewed changes

dreispt linked an issue Mar 20, 2024 that may be closed by this pull request

base_dav dead? #254

Open

dreispt mentioned this pull request Mar 20, 2024

[MIG] base_dav: Migration to 17.0 #276

Draft

flotho suggested changes Jul 11, 2024

View reviewed changes

SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024

Merge pull request OCA#269 from OCA/12.0

d449ddb

Syncing from upstream OCA/server-backend (12.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] base_dav: Migration to 17.0 #269

[MIG] base_dav: Migration to 17.0 #269

jaydeep32 commented Feb 14, 2024 •

edited

Loading

jaydeep32 commented Mar 18, 2024

dreispt commented Mar 19, 2024

jaydeep32 commented Mar 19, 2024

dreispt commented Mar 20, 2024

jaydeep32 commented Mar 20, 2024

dreispt Mar 20, 2024

jaydeep32 Mar 20, 2024

dreispt Mar 20, 2024

amh-mw left a comment

dreispt commented Mar 20, 2024

dreispt commented Mar 20, 2024

flotho left a comment •

edited

Loading

flotho commented Jul 11, 2024

eLBati commented Jul 29, 2024

josselex commented Oct 5, 2024

[MIG] base_dav: Migration to 17.0 #269

Are you sure you want to change the base?

[MIG] base_dav: Migration to 17.0 #269

Conversation

jaydeep32 commented Feb 14, 2024 • edited Loading

jaydeep32 commented Mar 18, 2024

dreispt commented Mar 19, 2024

jaydeep32 commented Mar 19, 2024

dreispt commented Mar 20, 2024

jaydeep32 commented Mar 20, 2024

dreispt Mar 20, 2024

Choose a reason for hiding this comment

jaydeep32 Mar 20, 2024

Choose a reason for hiding this comment

dreispt Mar 20, 2024

Choose a reason for hiding this comment

amh-mw left a comment

Choose a reason for hiding this comment

dreispt commented Mar 20, 2024

dreispt commented Mar 20, 2024

flotho left a comment • edited Loading

Choose a reason for hiding this comment

flotho commented Jul 11, 2024

eLBati commented Jul 29, 2024

josselex commented Oct 5, 2024

jaydeep32 commented Feb 14, 2024 •

edited

Loading

flotho left a comment •

edited

Loading