[IMP] add guidelines about website features #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Odoo 14.0 recommends running HttpCase tests on `post_install` mode only][1]. This can help on certain situations, but increments chances of some website modules polluting others. One simple and common example are `website_sale` extensions in the OCA/e-commerce repo. If a module adds the phone as a required field and another module adds the VAT as required field, when both are installed and both test the checkout workflow, both will probably fail because none of them would be filling the other required field. Note that this is still possible without the `post_install` mode; this just increments the possibilites. In any case, since Odoo v12, we have multiple websites. So, any module that alters Odoo upstream behavior should have those alterations disabled by default, expecting the user to enable them only in the website(s) they want. This should make tests integrate properly out of the box, and should make all website addons more reliable, but it is not obvious, so I think this should be documented into a guideline. [1]: https://github.com/odoo/odoo/blob/9b0578766709b27c91d85bf6246b4bc5e43ca27d/odoo/tests/common.py#L1377 @Tecnativa TT25963
|
Hi Yajo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odoo 14.0 recommends running HttpCase tests on
post_installmode only. This can help on certain situations, but increments chances of some website modules polluting others.One simple and common example are
website_saleextensions in the OCA/e-commerce repo. If a module adds the phone as a required field and another module adds the VAT as required field, when both are installed and both test the checkout workflow, both will probably fail because none of them would be filling the other required field. Note that this is still possible without thepost_installmode; this just increments the possibilites.In any case, since Odoo v12, we have multiple websites. So, any module that alters Odoo upstream behavior should have those alterations disabled by default, expecting the user to enable them only in the website(s) they want.
This should make tests integrate properly out of the box, and should make all website addons more reliable, but it is not obvious, so I think this should be documented into a guideline.
@Tecnativa TT25963