-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] l10n_us_gaap #132
base: 17.0
Are you sure you want to change the base?
Conversation
[IMP] adding first unit tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-usa-16.0/l10n-usa-16.0-l10n_us_gaap Translate-URL: https://translation.odoo-community.org/projects/l10n-usa-16-0/l10n-usa-16-0-l10n_us_gaap/
l10n_us_gaap/tests/test_base_us.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests deleted during migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because it will try to load the module again and will try to create a new account and can cause issue of duplicate account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to specify the companies to apply and template while loading the coa, something like:
try_loading(template_code="us_gaap", company=self.company, install_demo=False)
l10n_us_gaap/tests/test_base_us.py
Outdated
self.env.user.write( | ||
{"company_ids": [(4, self.company.id)], "company_id": self.company.id} | ||
) | ||
chart_us.try_loading() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here #132 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, its updated.
f23b798
to
7e6d862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍
/ocabot migration l10n_us_gaap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed on Runboat, looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. otherwise I think U could apply some of my suggestions.
l10n_us_gaap/readme/USAGE.md
Outdated
|
||
This module contains in the 'docs' folder a a sample Trial Balance | ||
generated using the [OCA Account Financial Report | ||
module](https://github.com/OCA/account-financial-reporting/blob/12.0/account_financial_report). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update url to v17 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been really good if this file had been generated recently.
7e6d862
to
e0b8ce2
Compare
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Standard Migration
Adapt 17.0 chart of account related changes, and remove tests as it will try to load the module again and will try to create a new account and can cause issue of duplicate account
@ForgeFlow