Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_us_gaap #132

Open
wants to merge 27 commits into
base: 17.0
Choose a base branch
from

Conversation

JasminSForgeFlow
Copy link

Standard Migration

Adapt 17.0 chart of account related changes, and remove tests as it will try to load the module again and will try to create a new account and can cause issue of duplicate account

@ForgeFlow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests deleted during migration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it will try to load the module again and will try to create a new account and can cause issue of duplicate account

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to specify the companies to apply and template while loading the coa, something like:

try_loading(template_code="us_gaap", company=self.company, install_demo=False)

self.env.user.write(
{"company_ids": [(4, self.company.id)], "company_id": self.company.id}
)
chart_us.try_loading()
Copy link

@LoisRForgeFlow LoisRForgeFlow Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, its updated.

Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@yvaucher
Copy link
Member

/ocabot migration l10n_us_gaap

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 30, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 30, 2024
4 tasks
Copy link

@jelenapoblet jelenapoblet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on Runboat, looking good

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. otherwise I think U could apply some of my suggestions.


This module contains in the 'docs' folder a a sample Trial Balance
generated using the [OCA Account Financial Report
module](https://github.com/OCA/account-financial-reporting/blob/12.0/account_financial_report).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update url to v17 branch.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been really good if this file had been generated recently.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.