Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] cooperator[_website]: Improve form #116

Open
wants to merge 12 commits into
base: 16.0
Choose a base branch
from
Open

[IMP] cooperator[_website]: Improve form #116

wants to merge 12 commits into from

Commits on Mar 4, 2024

  1. [IMP] cooperator: Improve form 

    Better names, move important fields to the start

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    bff86e4 View commit details
    Browse the repository at this point in the history

  2. [IMP] cooperator[_website]: Factor out already_cooperator 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0b31765 View commit details
    Browse the repository at this point in the history

  3. [IMP] cooperator: Title sections in subscription form view 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    56c25e9 View commit details
    Browse the repository at this point in the history

  4. [FIX] cooperator: Make subscription type mandatory 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a4c3387 View commit details
    Browse the repository at this point in the history

  5. [IMP] cooperator: Clarify that account № is bank account № 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    28bb786 View commit details
    Browse the repository at this point in the history

  6. [IMP] cooperator: Write test case for onchange partner_id 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a01d4eb View commit details
    Browse the repository at this point in the history

  7. [IMP] cooperator: Force 'increase' type if already cooperator 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    168c3d0 View commit details
    Browse the repository at this point in the history

  8. [IMP] cooperator: subscription information form in backend

    @victor-champonnois @carmenbianca
    victor-champonnois authored and carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9da1b25 View commit details
    Browse the repository at this point in the history

  9. [IMP] cooperator: subscription.request type is now computed

    @victor-champonnois @carmenbianca
    victor-champonnois authored and carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c5a6b20 View commit details
    Browse the repository at this point in the history

  10. [FIX] cooperator: tests 

    the field type is computed such that it's 'increase' only if the sub
request is linked with a partner that is a member. This contradicts
previous tests according the which a sub request for a non member
partner should have a type 'increase'
    @victor-champonnois @carmenbianca
    victor-champonnois authored and carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5667a50 View commit details
    Browse the repository at this point in the history

  11. [FIX] cooperator: Remove superfluous checks 

    This is dead code since type and already_cooperator are both computed

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1d7e5dc View commit details
    Browse the repository at this point in the history

  12. [FIX] cooperator: Remove dead code that adjusts 'type' 

    type is computed. This code is now superfluous.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ab5ce53 View commit details
    Browse the repository at this point in the history