Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ssh2 to 1.6.0+ #399

Closed
NuSkooler opened this issue Feb 2, 2022 · 3 comments
Closed

Update ssh2 to 1.6.0+ #399

NuSkooler opened this issue Feb 2, 2022 · 3 comments
Assignees
@NuSkooler
Labels
dependencies Pull requests that update a dependency file help wanted high prio High Priority Issues
Milestone
0.0.13-beta

Comments

@NuSkooler
Copy link
Owner

Update ssh2 to version 1.6.0 or higher. Security + improved speeds.

See mscdex/ssh2#935
@NuSkooler NuSkooler self-assigned this Apr 8, 2022
@NuSkooler
Copy link
Owner Author

Should be finishing this one up soon.

There seems to be a off-by-one display error with NetRunner: A wildly incorrect value is sent for term height over SSH & NR does not support our ESC seq size query hack. If anyone has ideas...

@NuSkooler NuSkooler added high prio High Priority Issues dependencies Pull requests that update a dependency file labels Apr 8, 2022
@NuSkooler NuSkooler added this to the 0.0.13-beta milestone Apr 8, 2022
@NuSkooler
Copy link
Owner Author

There seems to be much bigger issue with NetRunner the updated SSH2: NR freezes if you aren't constantly giving it input.

@NuSkooler NuSkooler mentioned this issue Sep 8, 2023
Closed
@cognitivegears
Copy link
Collaborator

Note - I've updated ssh2 with #515. As far as formatting on Netrunner, I think that's probably covered in some of the recent PRs. I haven't seen the hang on Netrunner, but I'll do some more testing on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NuSkooler NuSkooler

Labels
dependencies Pull requests that update a dependency file help wanted high prio High Priority Issues
Projects
None yet
Milestone
0.0.13-beta
Development

No branches or pull requests
2 participants
@NuSkooler @cognitivegears