From c591f30385b0c31ce31cceb1bedd88c91e198c30 Mon Sep 17 00:00:00 2001
From: Alexis Mousset <alexis.mousset@rudder.io>
Date: Mon, 9 Oct 2023 11:57:03 +0200
Subject: [PATCH] Fixes #23545: Parameter name in metadata.xml should be its
 uppercased id

---
 policies/rudderc/src/backends/metadata.rs     |  2 +-
 .../tests/cases/general/escaping/metadata.xml |  2 +-
 .../tests/cases/general/form/metadata.xml     | 26 +++++++++----------
 .../tests/cases/general/ntp/metadata.xml      |  2 +-
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/policies/rudderc/src/backends/metadata.rs b/policies/rudderc/src/backends/metadata.rs
index 1f6c26dd8a9..b8e0bf30e5f 100644
--- a/policies/rudderc/src/backends/metadata.rs
+++ b/policies/rudderc/src/backends/metadata.rs
@@ -95,7 +95,7 @@ impl From<Parameter> for Input {
         };
 
         Self {
-            name: p.id.to_string(),
+            name: p.id.to_string().to_uppercase(),
             description: p.name,
             long_description: p.description,
             constraint: Constraint {
diff --git a/policies/rudderc/tests/cases/general/escaping/metadata.xml b/policies/rudderc/tests/cases/general/escaping/metadata.xml
index ecfdd85926e..f3aaf4c4d53 100644
--- a/policies/rudderc/tests/cases/general/escaping/metadata.xml
+++ b/policies/rudderc/tests/cases/general/escaping/metadata.xml
@@ -26,7 +26,7 @@
   <SECTIONS>
     <SECTION name="Technique parameters">
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27e</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27E</NAME>
         <DESCRIPTION>server</DESCRIPTION>
         <LONGDESCRIPTION>${sys.host} . | / ${sys.${host}} &apos; &apos;&apos; &apos;&apos;&apos; $ $$ &quot; &quot;&quot; \ \\😋aà3</LONGDESCRIPTION>
         <CONSTRAINT>
diff --git a/policies/rudderc/tests/cases/general/form/metadata.xml b/policies/rudderc/tests/cases/general/form/metadata.xml
index 50e5a9a3bfa..25dee4bddd4 100644
--- a/policies/rudderc/tests/cases/general/form/metadata.xml
+++ b/policies/rudderc/tests/cases/general/form/metadata.xml
@@ -26,7 +26,7 @@
   <SECTIONS>
     <SECTION name="Technique parameters">
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27a</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27A</NAME>
         <DESCRIPTION>server_a</DESCRIPTION>
         <LONGDESCRIPTION>description</LONGDESCRIPTION>
         <CONSTRAINT>
@@ -34,7 +34,7 @@
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27b</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27B</NAME>
         <DESCRIPTION>server_b</DESCRIPTION>
         <LONGDESCRIPTION>The server hostname</LONGDESCRIPTION>
         <CONSTRAINT>
@@ -61,21 +61,21 @@
         </CONSTRAINT>
       </SELECT1>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27d</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27D</NAME>
         <DESCRIPTION>server_d</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>mail</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27e</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27E</NAME>
         <DESCRIPTION>server_e</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>boolean</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27f</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27F</NAME>
         <DESCRIPTION>server_f</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>password</TYPE>
@@ -83,7 +83,7 @@
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27g</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27G</NAME>
         <DESCRIPTION>server_g</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>password</TYPE>
@@ -91,42 +91,42 @@
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27h</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27H</NAME>
         <DESCRIPTION>server_h</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>perm</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27i</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27I</NAME>
         <DESCRIPTION>server_i</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>size-gb</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27j</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27J</NAME>
         <DESCRIPTION>server_j</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>textarea</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27k</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27K</NAME>
         <DESCRIPTION>server_k</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>ipv6</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27l</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27L</NAME>
         <DESCRIPTION>server_l</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>textarea</TYPE>
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27m</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27M</NAME>
         <DESCRIPTION>server_m</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>integer</TYPE>
@@ -134,7 +134,7 @@
         </CONSTRAINT>
       </INPUT>
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27n</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27N</NAME>
         <DESCRIPTION>server_n</DESCRIPTION>
         <CONSTRAINT>
           <TYPE>textarea</TYPE>
diff --git a/policies/rudderc/tests/cases/general/ntp/metadata.xml b/policies/rudderc/tests/cases/general/ntp/metadata.xml
index f2578110030..b46195ebd10 100644
--- a/policies/rudderc/tests/cases/general/ntp/metadata.xml
+++ b/policies/rudderc/tests/cases/general/ntp/metadata.xml
@@ -35,7 +35,7 @@
   <SECTIONS>
     <SECTION name="Technique parameters">
       <INPUT>
-        <NAME>3439bbb0-d8f1-4c43-95a9-0c56bfb8c27e</NAME>
+        <NAME>3439BBB0-D8F1-4C43-95A9-0C56BFB8C27E</NAME>
         <DESCRIPTION>server</DESCRIPTION>
         <LONGDESCRIPTION>The server hostname</LONGDESCRIPTION>
         <CONSTRAINT>