Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview of dataset issues #320

Open
YanchunHe opened this issue Sep 16, 2022 · 7 comments
Open

Overview of dataset issues #320

YanchunHe opened this issue Sep 16, 2022 · 7 comments
Assignees

Comments

@YanchunHe
Copy link
Collaborator

YanchunHe commented Sep 16, 2022

Last update: 13rd April, 2023

Webpage to compile identified dataset issues (using gh-page):

http://noresmhub.github.io/noresm2cmor/issues.html

To edit this page, click this link

To add new entries right below the comment line:

	        <!-- ADD NEW ENTRY RIGHT BELOW HERE-->
	        <!-- USE EXISTING ONES AS TEMPLATE-->
			<tr>
				<td>fLuc</td>
				<td>Lmon</td>
				<td>historical</td>
				<td>NorESM2-LM</td>
				<td>#319</td>
			  	<td>open</td>
			</tr>
@YanchunHe
Copy link
Collaborator Author

YanchunHe commented Sep 16, 2022

Hi,

I get to know some would create a page/documentation to list the identified errors in the published datasets in addition to ESDoc Errata, to make more accessible to domestic users for NorESM output for CMIP5/6.

Here I initiate this discussion, and any ideas and comments are appreciated!

Option 1, use markdown in-line table in Github Issue or Wiki page

(I wold prefer Pinned Github Issue page).

Variable Table ID Issue Experiment Model null
fLuc Lmon #319 historical NorESM2-LM
fHarvest Lmon #319 historical NorESM2-LM
wap 6hrPlev #316 ssp585, * NorESM2-LM
co2 AERmon #315 piControl NorESM2-LM

Option 2, html table with search/filter for variable

I can create a html page with search/filter, an example:
(an update, I host the html page on the GitHub-pages)
http://noresmhub.github.io/noresm2cmor/

However, such html code can not be directly embed in Github Issue or Wiki pages.

@TomasTorsvik
Copy link

Hi @YanchunHe ,

if it is enough with a simple table, I think it would be best to have it integrated on the github platform and make use of the existing Wiki page. I would prefer this solution over a pinned github issue page, since the wiki can be edited by everyone, whereas in an issue we can only edit our own comments. Maybe you can elaborate on why you prefer to have it as an issue?

At the moment I don't think we need a search/filter option ('ctrl + f' in a web page works fine for short lists), but I see the point of having this option if the list grows into the hundreds. At the moment I see 31 NCC-related issued on the ES-Doc Errata page. Do we anticipate to have a significantly higher number for the list we are discussing now?

@YanchunHe
Copy link
Collaborator Author

Thanks, @TomasTorsvik for your good suggestions!

I would prefer this solution over a pinned github issue page, since the wiki can be edited by everyone, whereas in an issue we can only edit our own comments.

This is a good point if all the users would like to add an entry for identified error. My thinking is that the GitHub Issues is always more 'visible' to people, so that they can easily spot there is a compiled list of datasets with errors.

At the moment I don't think we need a search/filter option ('ctrl + f' in a web page works fine for short lists), but I see the point of having this option if the list grows into the hundreds. At the moment I see 31 NCC-related issued on the ES-Doc Errata page. Do we anticipate to have a significantly higher number for the list we are discussing now?

We can use a static table in wiki. As it would stay clean in the wiki format, so that it should be fine with limited amount of entries.

@adagj
Copy link
Collaborator

adagj commented Sep 19, 2022

Hi @YanchunHe !
Great that you are looking into this, and a table sounds like a good idea. I think one challenge is that issues concerning data errors have been closed without actually fixing the error or providing the information elsewhere; e.g the sea ice lat/lon boundaries. Can we also add closed issues to the table? Then it may be a quite extensive table after a while.

@YanchunHe
Copy link
Collaborator Author

Yes, @adagj we can include the previously closed issues. I was thinking to add a 'status' column to this table, something as 'fixed', 'closed', "will not fix", "errata reported", or something similar.

If considering its expansion and to make it searchable, I would then recommend a github-pages, or even simply just use an external spreadsheet, such as google sheet (everyone can edit or only those with granted permission?)

@adagj
Copy link
Collaborator

adagj commented Sep 19, 2022

Hi,
I think to add a status column is a very good idea and sufficient. I think it is important to make it very easy to maintain so we actually manage to maintain it :-)

@YanchunHe YanchunHe unpinned this issue Oct 27, 2022
@YanchunHe YanchunHe pinned this issue Oct 27, 2022
@YanchunHe YanchunHe changed the title [Discussion] Datasets with Identified Errors or Issues Overview of dataset issues Apr 13, 2023
@YanchunHe
Copy link
Collaborator Author

YanchunHe commented Apr 13, 2023

Hi, please see the update page at the top for compiling the identified dataset issues!
@adagj @monsieuralok @MichaelSchulzMETNO @TomasTorsvik

@YanchunHe YanchunHe unpinned this issue Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants