Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shadow file #ifdef content from non oslo-aero code base #131

Open
mvertens opened this issue Jan 30, 2024 · 2 comments
Open

Remove shadow file #ifdef content from non oslo-aero code base #131

mvertens opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mvertens
Copy link

Issue Type

Code Clean-up

Issue Description

The current implementation of shadow files unfortunately also populated the original non-shadow file code with the #ifdefs of the shadow files. This needs to be undone and all the changes should be solely contained in the shadow files in src_cam in the oslo_aero code base.

Will this change answers?

No

Will you be implementing this yourself?

Yes

@oyvindseland
Copy link

Question on status: The remaining ifdef now is the ifdef AEROCOM that should be replaced by namelist?
--> Likely too late for 2.3.0, but can still be done for 2.3.1 ? @mvertens

@gold2718
Copy link

The only ifdef AEROCOM left is in cam_diagnostics which is still there even in noresm_development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants