Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of the first segment as the longest one of frequency range after jump correction #1

Open
ghraecakter opened this issue Aug 9, 2018 · 0 comments

Comments

@ghraecakter
Copy link

Hi Lili,

After jump correction, the frequency range is divided into multiple segments by jump points.
However, your code neglects the possibility that the first segment being the longest

pyaftan/pyaftan.py

Lines 633 to 634 in 976efd2

indx = np.where(np.abs(trig)>0.5)[0]
indx = np.append(indx, nfin-1)

I'm wondering if you deliberately did it or overlooked Misha's original code

indx(1) = 1

If it's the former case, my guess is that you always want to save the longer periods.
If it's the latter, a possible fix would be

indx = np.concatenate(([0], indx, [nfin-1]))

Best,
Shane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant