-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TV series #5
Comments
Hi there, thanks for opening the issue! Yes, this is in my roadmap but I don't have a date for it. In order to set expectations, let me tell you that I don't think it'll happen until early next year. Before getting into new features, I still have a couple of things I want to improve. And it's likely that I start working on another app before I add this feature. But I'll eventually add it for sure, because it's something I am missing in my own use of the app. If anyone wants to help with this, I'm willing to accept PRs and suggestions. But given the impact of this feature, it'll probably be a slow process and I'll give a lot of push back. In case anyone still wants to proceed, here's a couple of things I have in mind:
|
I don't mind a slow process and discussions, I could reinvent the wheel, but this app is just really polished and works really well :)
I will think about some containers and document structure and add it to this issue later. I think we can re-use a lot of the current structure and even be backwards compatible 🎉
I think this is another feature. I see this as an update operation which can be used for more than just TV shows.
True, this should be more like 'media' instead of 'movies'. Besides these things, I also have the following in mind:
|
@NoelDeMartin Which software do you use to generate these UML diagrams? Umbrello doesn't seem to support this file type: https://github.com/NoelDeMartin/media-kraken/blob/main/docs/classes.uml |
Yes, I agree that it is a different feature. But I wouldn't release a version without it because it's essential to the use-case. But yeah, the first version could be something as simple as a button to synchronise. Although I'd see if there is a simple way that doesn't require user interaction :).
I like the idea of showing the number, but the workflow to mark watched should be done per-episode. I may have 7 pending and want to mark that I've watched one without the necessity to open the TV show page. Right now the watched mark is binary for movies, and it serves both as a visual queue and a button. Maybe for TV shows it should be different. Here's how it works in TViso, the app I'm using that I plan to replace with Media Kraken:
👍
TMDB also supports TV shows, any reason not to use the same API?
This is also something I've thought about but I'm not sure when I'll do it. So far, I'm using it as a PWA both on my Android device and in Ubuntu, and it works well. I'm not sure if the linux phone supports it though. I've thought about packaging the app with electron and cordova/capacitor. But since I don't have the necessity, I don't plan on doing it anytime soon unless many people ask for it. For mobile phones it'd also mean having to use appstores, and so far I like that this is only using github pages for deployment. You can open a separate issue about this if you want.
This is also a different feature, you can also open a different issue if you want. But I'm not sure I like this one. Maybe I wouldn't mind adding it if it isn't intrusive in the UI, but I feel the challenge here would be in the data because you'd need to store the duration in Solid models as well.
I'm not too happy with the diagrams, so I'm open to suggestions. But I wanted a solution that treats diagrams as code instead binaries. I came across PlantUML and I thought it was good enough. You can regenerate the images running |
Oh I must have missed that, the name of the website doesn't really reflect that. Let's use TMDB then!
I will receive my PinePhone in about 2 - 3 weeks and I will be happy to do that. I'm in favor of keeping this out of this repository, I would avoid to bloat this repository with such things.
Yes, we need to store the duration as well here. All other information is already there, so I don't see any big problems here.
If we manage to achieve that, it would so awesome 🎉
Completely agree! In my TV show app, I can mark a full season as watched, a complete TV show or a single episode. First proposal for the 'new' data structure PlanetUML is having some issues with the structure :( I'm not an UI wizard, if I do some UI here, I will do my best, feel free to suggest things :) |
I'd rather keep it in the same repository, after all the code is the same. I don't expect having to do much native code, it'd just be different deployment targets. I haven't heard of QtWebengine nor pywebview, but I think Electron and Cordova are good options. Or Capacitor :).
Do you have a link to that app?
Don't worry about that, if your code is not ready for release I can still create a feature branch and merge your PR there. I can improve the UI later on, any help I get is already appreciated :). About the classes diagram, a couple of things:
|
https://openrepos.net/content/corecomic/seriesfinale-sailfish-os
👍
True, but maybe in a separate folder to keep the specifics out of the code base
Interesting! I will have a look soon :)
Yes, I was confused about these things, but now that you explain it, I totally get it :)
Sure, these things are not written in stone :D Series,Season,Episode sounds nice, otherwise we are too fixed on TV stuff (TVEpsiode doesn't completely fit in when we have a show that's only available through streaming services).
PosterURL might be overkill, but externalUrl might be not. You can use that to link to a specific episode on TMDB or IMDB for example: https://www.imdb.com/title/tt1724327/?ref_=ttep_ep15 |
I just discovered this nice app, congratz!
In the past, I was also tinkering about such a Solid app but for TV series.
These links can be useful I think:
This would fit nicely into the data schema as
schema:TVSeries
instead ofschema:Movie
.I saw this was on your roadmap somehow, maybe we can discuss a bit to proceed with this?
The text was updated successfully, but these errors were encountered: