Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new sections to FAQs #238

Closed
wants to merge 2 commits into from
Closed

Conversation

MMenchero
Copy link
Contributor

Work in Progress (WIP)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MMenchero MMenchero marked this pull request as draft March 6, 2024 05:56
@MMenchero MMenchero marked this pull request as ready for review March 7, 2024 04:47
@MMenchero MMenchero requested review from AzulGarza and cchallu March 7, 2024 04:47
@@ -8,6 +8,34 @@
"# FAQS"
Copy link
Member

@AzulGarza AzulGarza Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a reference here on how to generate a token from dashboard?


Reply via ReviewNB

@AzulGarza AzulGarza self-requested a review March 7, 2024 07:16
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @MMenchero! it's looking great! i left a small comment.

regarding the structure, i feel that we can improve it, but i'm not 100% sure how. i'm thinking for example, we could migrate some parts of the long horizon, exogenous, finetunning and large datasets sections to their corresponding tutorials and left the rest of the sections here. @mergenthaler, wdyt?

@AzulGarza
Copy link
Member

also, could you open the pr directly from a branch? apparently there is a problem with the environment variables when a pr is created from a fork, and it breaks the ci/cd, learned that today 😅

@mergenthaler
Copy link
Member

Thanks @MMenchero and @AzulGarza! Regarding structure, it would make sense for the FAQS to have questions with very short answers and links to the necessary documentation.

Here are some examples:
https://help.openai.com/en/articles/6783457-what-is-chatgpt
https://support.anthropic.com/en/collections/4078531-claude-ai

@MMenchero
Copy link
Contributor Author

Thanks @AzulGarza and @mergenthaler for the feedback. I'm on it. I also struggled with the structure because some of the original answers are long and duplicate what's in the tutorials. I'll use the references Max gave me to make more changes. And I'll open the PR from a branch because if I do it from a fork, the token is not included and several tests fail.

@MMenchero MMenchero mentioned this pull request Mar 12, 2024
@MMenchero MMenchero closed this Mar 12, 2024
@MMenchero
Copy link
Contributor Author

I'm going to close this PR since I created a new version #250 that was opened directly from a branch instead of a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants