-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new sections to FAQs #238
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -8,6 +8,34 @@ | |||
"# FAQS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @MMenchero! it's looking great! i left a small comment.
regarding the structure, i feel that we can improve it, but i'm not 100% sure how. i'm thinking for example, we could migrate some parts of the long horizon, exogenous, finetunning and large datasets sections to their corresponding tutorials and left the rest of the sections here. @mergenthaler, wdyt?
also, could you open the pr directly from a branch? apparently there is a problem with the environment variables when a pr is created from a fork, and it breaks the ci/cd, learned that today 😅 |
Thanks @MMenchero and @AzulGarza! Regarding structure, it would make sense for the FAQS to have questions with very short answers and links to the necessary documentation. Here are some examples: |
Thanks @AzulGarza and @mergenthaler for the feedback. I'm on it. I also struggled with the structure because some of the original answers are long and duplicate what's in the tutorials. I'll use the references Max gave me to make more changes. And I'll open the PR from a branch because if I do it from a fork, the token is not included and several tests fail. |
I'm going to close this PR since I created a new version #250 that was opened directly from a branch instead of a fork. |
Work in Progress (WIP)