Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Increase max wait time to catch ReadTimeout exception #147

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

AzulGarza
Copy link
Member

By default, our client uses 60 seconds as timeout. Before this PR max_wait_time=60, which couldn't catch ReadTimeout correctly.
To fix this, this PR sets max_wait_time=360. A test reflecting this behavior was included.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AzulGarza AzulGarza changed the title [FIX] Increase max wait time to cath ReadTimeout exception [FIX] Increase max wait time to catch ReadTimeout exception Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Experiment 1: air-passengers

Description:

variable experiment
h 12
season_length 12
freq MS
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 12.6793 47.8333 76
mape 0.027 0.0999 0.1425
mse 213.936 2571.33 10604.2
total_time 6.6559 6.6026 0.5965

Plot:

Experiment 2: air-passengers

Description:

variable experiment
h 24
season_length 12
freq MS
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 58.1031 71.25 115.25
mape 0.1257 0.1552 0.2358
mse 4040.21 5928.17 18859.2
total_time 9.2003 0.0058 0.0054

Plot:

Experiment 3: electricity-multiple-series

Description:

variable experiment
h 24
season_length 24
freq H
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 4.8617 5.6289 5.2381
mape 0.6816 0.7654 0.6328
mse 40.5749 63.023 50.8454
total_time 2.2065 0.0127 0.0123

Plot:

Experiment 4: electricity-multiple-series

Description:

variable experiment
h 168
season_length 24
freq H
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 8.3102 9.3176 12.6464
mape 1.382 1.0786 1.4208
mse 165.13 202.596 336.086
total_time 3.3838 0.0143 0.0142

Plot:

Experiment 5: electricity-multiple-series-with-ex-vars

Description:

variable experiment
h 24
season_length 24
freq H
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 5.5206 5.6289 5.2381
mape 0.4674 0.7654 0.6328
mse 40.9623 63.023 50.8454
total_time 4.7237 0.6617 0.4012

Plot:

Experiment 6: electricity-multiple-series-with-ex-vars

Description:

variable experiment
h 168
season_length 24
freq H
level None
n_windows 1

Results:

metric TimeGPT SeasonalNaive Naive
mae 7.5605 9.3176 12.6464
mape 1.371 1.0786 1.4208
mse 135.78 202.596 336.086
total_time 6.3015 0.0171 0.0165

Plot:

@AzulGarza AzulGarza merged commit 73bcf65 into main Nov 7, 2023
12 checks passed
@AzulGarza AzulGarza deleted the fix/time-out branch November 7, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant