Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofborg doesn't apply changes from PR before kicking off builds on aarch64-darwin sometimes. #676

Open
ghost opened this issue Feb 18, 2024 · 3 comments

Comments

@ghost
Copy link

ghost commented Feb 18, 2024

I've seen this twice on aarch64-darwin over the 200*(not all logs from builds are still available) builds done for one PR but not on other architectures.

NixOS/nixpkgs#288913 updates duckdb from version 0.9.2 -> 0.10.0, duckdb-engine 0.9.2 -> 0.11.1, and sqlglot:20.9.0 -> 21.1. the most recent ofborg run did not apply changes from the PR before kicking off the aarch64-darwin build log and previous failure is log

these 4 paths will be fetched (40.70 MiB download, 262.77 MiB unpacked):
  /nix/store/sr1avx59qyldsd5fxmka8x8z743jynz7-duckdb-0.9.2
  /nix/store/py4ng5kv65xqjjdqyzvq9hgwxmza59ll-python3.11-duckdb-0.9.2
  /nix/store/5jj2gd8al950g11996809xfh5x30w6f0-python3.11-duckdb-engine-0.9.2
  /nix/store/x1jwv26lyl3z5zx019jwy2qx1qw6gv1l-python3.11-sqlglot-20.9.0
copying path '/nix/store/sr1avx59qyldsd5fxmka8x8z743jynz7-duckdb-0.9.2' from 'https://cache.nixos.org'...
copying path '/nix/store/py4ng5kv65xqjjdqyzvq9hgwxmza59ll-python3.11-duckdb-0.9.2' from 'https://cache.nixos.org'...
copying path '/nix/store/x1jwv26lyl3z5zx019jwy2qx1qw6gv1l-python3.11-sqlglot-20.9.0' from 'https://cache.nixos.org'...
copying path '/nix/store/5jj2gd8al950g11996809xfh5x30w6f0-python3.11-duckdb-engine-0.9.2' from 'https://cache.nixos.org'...
/nix/store/sr1avx59qyldsd5fxmka8x8z743jynz7-duckdb-0.9.2
/nix/store/py4ng5kv65xqjjdqyzvq9hgwxmza59ll-python3.11-duckdb-0.9.2
/nix/store/5jj2gd8al950g11996809xfh5x30w6f0-python3.11-duckdb-engine-0.9.2
/nix/store/x1jwv26lyl3z5zx019jwy2qx1qw6gv1l-python3.11-sqlglot-20.9.0

this is wrong -- notice all the versions are old and cached. nothing was built, just copied from cache.nixos.org.

contrast this to the build on x86_64-darwin below log

these 4 derivations will be built:
  /nix/store/0fw8sf8g84fjp751xn92ndcv0qx98sfz-python3.11-duckdb-0.10.0.drv
  /nix/store/iqib6vgd0352x5787fiv8wql6hiwmi54-duckdb-0.10.0.drv
  /nix/store/mnsk4pbs4sv9nzjbfs0mljw6rwlzyamv-python3.11-sqlglot-21.1.1.drv
  /nix/store/prvk06j9a2gq3by88nci3lgn5c5ylss5-python3.11-duckdb-engine-0.11.1.drv
building '/nix/store/iqib6vgd0352x5787fiv8wql6hiwmi54-duckdb-0.10.0.drv'...
building '/nix/store/0fw8sf8g84fjp751xn92ndcv0qx98sfz-python3.11-duckdb-0.10.0.drv'...
[...] 1000s of lines of build logs ...
/nix/store/6lh8bzhhj0h862cll4s60h2shy3fzqqw-duckdb-0.10.0
/nix/store/k1wn8bcq963p9gsgznp7yc4wdvx5a006-python3.11-duckdb-0.10.0
/nix/store/044d9cmidzxl9sgiv1k8f26nbvg3wc3r-python3.11-duckdb-engine-0.11.1
/nix/store/6dwfw7h5xy5zzinvaf8g8my9g1y8wff5-python3.11-sqlglot-21.1.1

this built all packages listed in the PR commit messages and the version numbers are correct.

here is a log of when aarch64-darwin did build using the changes of the PR, however, the log is truncated.

[*] yikes

@mweinelt
Copy link
Member

Use python311Packages, not python3Packages for one. #577

@ghost
Copy link
Author

ghost commented Feb 18, 2024

Use python311Packages, not python3Packages for one. #577

I am using python311Packages in the commit message and there is one non-python package getting built, duckdb, and the other architectures are building the changes from the PR fine.
https://github.com/NixOS/nixpkgs/pull/288913/commits

$ git log --oneline -3
6cb452d14e3f python311Packages.sqlglot: 20.9.0 -> 21.1.1
69efda763051 python311Packages.duckdb-engine: 0.9.2 -> 0.11.1
3823e4ac04be duckdb,python311Packages.duckdb: 0.9.2 -> 0.10.0

so unfortunately, this does not seem to be the issue here.

@ghost ghost changed the title ofborg doesn't build using the specified PR sometimes. ofborg doesn't build using the changes specified in PR sometimes. Feb 18, 2024
@ghost ghost changed the title ofborg doesn't build using the changes specified in PR sometimes. ofborg doesn't build using the changes specified in PR on some architectures. Feb 18, 2024
@ghost ghost changed the title ofborg doesn't build using the changes specified in PR on some architectures. ofborg doesn't build using the changes specified in PR on aarch64-darwin sometimes. Feb 18, 2024
@ghost ghost changed the title ofborg doesn't build using the changes specified in PR on aarch64-darwin sometimes. ofborg doesn't apply changes from PR before kicking off builds on aarch64-darwin sometimes. Feb 18, 2024
@ghost
Copy link
Author

ghost commented Feb 20, 2024

here is one from x86_64-darwin log

the PR creates a new package. it seems that that path is not available when the build is triggered, thus the changes from the PR were not applied as seen in the log below.

Cannot nix-instantiate `recoverdm.passthru.tests' because:
error: attribute 'recoverdm' in selection path 'recoverdm.passthru.tests' not found

error: attribute 'recoverdm' in selection path 'recoverdm' not found

however, other builds ran fine as seen from the tail of the x64-linux log below

Oh, blatant plug: http://keetweej.vanheusden.com/wishlist.html
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8
shrinking /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8/bin/recoverdm
shrinking /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8/bin/mergebad
checking for references to /build/ in /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8...
gzipping man pages under /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8/share/man/
patching script interpreter paths in /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8
stripping (with command strip and flags -S -p) in  /nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8/bin
/nix/store/s8q35f3vjdl5ng3s26r8kl3y0nnyg1xs-recoverdm-0.20-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant