Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo-rs tracking issue #253465

Open
4 of 10 tasks
mkg20001 opened this issue Sep 5, 2023 · 8 comments
Open
4 of 10 tasks

sudo-rs tracking issue #253465

mkg20001 opened this issue Sep 5, 2023 · 8 comments
Labels
0.kind: enhancement Add something new 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS

Comments

@mkg20001
Copy link
Member

mkg20001 commented Sep 5, 2023

sudo-rs is coming to nixos

The roadmap

@mkg20001 mkg20001 added the 0.kind: bug Something is broken label Sep 5, 2023
@mkg20001 mkg20001 changed the title sudo-rs sudo-rs tracking issue Sep 5, 2023
@nyabinary
Copy link
Contributor

What patches need to be upstreamed?

@mkg20001 mkg20001 mentioned this issue Sep 5, 2023
7 tasks
@mkg20001
Copy link
Member Author

mkg20001 commented Sep 5, 2023

@nyabinary added

@winterqt winterqt added 0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS and removed 0.kind: bug Something is broken labels Sep 5, 2023
@nbraud
Copy link
Contributor

nbraud commented Sep 13, 2023

@mkg20001 Here's another upstream issue we need for full parity between sudo and sudo-rs, as far as extent NixOS modules are concerned.

@yorickvP
Copy link
Contributor

Another minor difference: It looks like sudo-rs does not support wildcards in arguments, opting to interpret them as literal wildcards instead

@squell
Copy link

squell commented Sep 20, 2023

The skip self check when run as root has been adopted by the sudo-rs team: trifectatechfoundation/sudo-rs#772.

@squell
Copy link

squell commented Sep 20, 2023

Another minor difference: It looks like sudo-rs does not support wildcards in arguments, opting to interpret them as literal wildcards instead

@yorickvP is correct, we actually actively removed that functionality here: trifectatechfoundation/sudo-rs#334 (in technical terms, changing the matcher for arguments from a glob::Pattern into a Option<Box<[String]>>).

@mkg20001
Copy link
Member Author

Another minor difference: It looks like sudo-rs does not support wildcards in arguments, opting to interpret them as literal wildcards instead

According to trifectatechfoundation/sudo-rs#333 it still works in the config, where it's necesarry.

In the shell, resolving wildcards should be the shell's responsibility. Bash will likely already do it for you if you un-quote the argument.

@samueldr samueldr added the 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems label Apr 23, 2024
@r-vdp
Copy link
Contributor

r-vdp commented Jan 16, 2025

Added trifectatechfoundation/sudo-rs#842 to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Development

No branches or pull requests

8 participants