variance in nada-numpy #75
Conversation
generated using `nada generate-test --test-name variance variance`
ghost
mentioned this pull request
| m = self.mean() | ||
|
|
||
| # Initialise the sum to 0 | ||
| sum = Integer(0) |
There was a problem hiding this comment.
Nada Numpy also supports SecretRational types. The function should also work for Rational types. You can probably look into the implementation of other functions to check for this.
| def nada_main(): | ||
| parties = na.parties(4) | ||
|
|
||
| a = na.array([4], parties[0], "A", SecretInteger) |
There was a problem hiding this comment.
Nada arrays do not require re-initialization of each of the entries. na.array already does the initialization of the SecretIntegers within it.
There was a problem hiding this comment.
This check is correct but doesn't check for other behaviors of the function and other datatypes. You should add the check for other variance values (!= 0) and for other datatypes (Rational, SecretRational).
| @@ -57,6 +57,7 @@ | |||
| "shuffle", | |||
| "array_comparison", | |||
| "private_inverse", | |||
| "var", | |||
There was a problem hiding this comment.
This should match the name of the Python executable, thus variance
|
|
||
| # compute (x_i - mean)^2 | ||
|
|
||
| for v in self.inner: |
There was a problem hiding this comment.
You should profit from broadcasting here. The function as it is, may not be working as you expect.
Resolves issue 62.