Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Replay buffer save trigger/notification #135

Open
ghost opened this issue Nov 4, 2022 · 3 comments
Open

[Feature Request] Replay buffer save trigger/notification #135

ghost opened this issue Nov 4, 2022 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 4, 2022

I see a button to start and stop the replay buffer, but it would be very nice to have one which allows us to save the buffer, and similarly, something to notify when a save has occurred (in case it is triggered from elsewhere, to confirm that it worked).

Thanks!

@Niek
Copy link
Owner

Niek commented Nov 7, 2022

It kind of makes sense but I struggle to see how to add more and more features like this without bloating the UI like crazy. We might need to put some stuff under an "advanced" button.

@ghost
Copy link
Author

ghost commented Nov 8, 2022

It kind of makes sense but I struggle to see how to add more and more features like this without bloating the UI like crazy.

I think you're wise to give it consideration... especially for a web-based app where the client might be a phone or smart refrigerator or something :D

I don't think this button should be obscured though, since if you're using the buffer this is the one button you'll need to press more readily than any other. Maybe put the 'stop buffer' button someplace else, and where the existing button is, the first click starts the buffer (like it does now), and if it's already started, subsequent clicks will save the buffer? (ie not a start/stop button but a start/save button)?

@lblabr
Copy link

lblabr commented Mar 1, 2023

great idea, i would it like too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants