"gleaming black runes" chest trap saving throw

[backwardsEric]

Noted by Chryana here, https://angband.live/forums/forum/angband/variants/10146-faangband-2-0-1?p=227577#post227577 , the saving throw against the effects of a "gleaming black runes" trap on a chest always seems to succeed.

The pval for the "gleaming black runes" trap is 16384. A player's value for SKILL_SAVE should at most be somewhat over 100 (level 50 dwarf priest with maximum wisdom and the MAGIC_RESISTANCE ability would have a SKILL_SAVE of 32 + (12 * 50) / 10 + 19 + 10 = 121). The test for a saving throw failure at effect-handler-general.c:3698 is "2 * context->obj->pval < player->state.skills[SKILL_SAVE]" which will always be false. FAangband 1.4.5 uses the equivalent of randint0(2 * context->obj->pval) >= player->state.skills[SKILL_SAVE] as the test for failing the saving throw (see cmd2.c:1282 and spells1.c:51).